This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Tweaks to get caching fully functional.#196
Open
peebles wants to merge 3 commits intostormpath:masterfrom
peebles:master
Open
Tweaks to get caching fully functional.#196peebles wants to merge 3 commits intostormpath:masterfrom peebles:master
peebles wants to merge 3 commits intostormpath:masterfrom
peebles:master
Conversation
https://api.stormpath.com/v1/applications/6fr66lFwpF8NTmFH0kITot/groups 2. Add recursive CacheHandler::get() 3. Recursive CacheHandler::put() was not storing the toplevel resource in some cases. 4. If process.env.NODE_DEBUG_SP=1, then print some debug statements when Stormpath fetches from cloud uri verses from cache. Also stores to cache are displayed.
Author
|
I see its failing lint checks, although it seems like the checks are pretty strict. If there was a lint "script" in package.json, I could run it and fix the lint errors, but as it I wouldn't know how you are running lint. Let me know if you want me to do anything to help. I noticed the npm module from doing a "npm install storm" is pretty far behind master... |
Author
|
I found that running "npm run test" ran lint. I fixed the lint errors. |
Member
|
Hi @peebles, thanks for this pull request. We've been busy with other features, but we will definitely review this as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://api.stormpath.com/v1/applications/6fr66lFwpF8NTmFH0kITot/groups
some cases.
fetches from cloud uri verses from cache. Also stores to cache are displayed.