bidi - async - remove cancelling call #1357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing another Python 3.11+ feature from bidi. Specifically, removing the asyncio
task.cancellingcall. This call was used in determining how to propagateasyncio.CancelledErrors in our_TaskGroupimplementation.Note, this PR is part of a larger effort to add Python 3.10 and 3.11 support to
bidi. The final PR for this work is currently in draft here.Related Issues
#1299
Documentation PR
N/A
Type of Change
Other (please describe): Compatibility update.
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run preparehatch run bidi:prepare: Relying on both existing and new unit testshatch run bidi-test:test tests_integ/bidiChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.