-
Notifications
You must be signed in to change notification settings - Fork 556
feat: allow custom-client for OpenAIModel #1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: allow custom-client for OpenAIModel #1366
Conversation
8ef2f27 to
bf7af85
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
bf7af85 to
5448261
Compare
5448261 to
0734f39
Compare
0734f39 to
3208acf
Compare
AraiYuno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
zastrowm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question/comment about the close method, but otherwise approved
3208acf to
1463df0
Compare
1463df0 to
b805bfc
Compare
b805bfc to
7eb595e
Compare
dbschmigelski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: lets just make sure the commit message also reflects that we are updating gemini too
7eb595e to
237357d
Compare
237357d to
9c98024
Compare
Description
Allow customer to pass custom client to OpenAIModel and GeminiModel. This solves the issue of [BUG] OpenAI Implementation does not support passing custom HTTP client.
Note
clientto be aclient_factoryin the future. Just as of now, this change only support the single client.Example
Users can now pass custom http client to the OpenAIModel and GeminiModel. Below is the example of the OpenAIModel.
Related Issues
#1036
Some parts of #1103
Documentation PR
Will update the documentation for this change.
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.