fix: add GPT-OSS stop tokens for tool-calling streams#1951
Open
saschabuehrle wants to merge 1 commit intostrands-agents:mainfrom
Open
fix: add GPT-OSS stop tokens for tool-calling streams#1951saschabuehrle wants to merge 1 commit intostrands-agents:mainfrom
saschabuehrle wants to merge 1 commit intostrands-agents:mainfrom
Conversation
saschabuehrle
requested a deployment
to
manual-approval
GitHub Actions
Waiting
saschabuehrle
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #1949 — GPT-OSS tool-calling streams can continue past the call boundary when no stop tokens are configured.
Fix
When formatting OpenAI chat requests, this adds GPT-OSS stop tokens (call, return, end) if the model id contains gpt-oss and no explicit stop parameter is set.
This keeps existing behavior intact for other models and preserves user-provided stop tokens.
Testing
Happy to address any feedback.
Greetings, saschabuehrle