Conversation
joscoh
force-pushed
the
josh/nested-type
branch
from
247bd81 to
783a7ca
Compare
shigoel
reviewed
Feb 3, 2026
shigoel
requested changes
Feb 3, 2026
Contributor
shigoel
left a comment
shigoel
left a comment
There was a problem hiding this comment.
LGTM, with one minor change in the error message wording.
Co-authored-by: Shilpi Goel <shigoel@gmail.com>
shigoel
approved these changes
Feb 4, 2026
aqjune-aws
approved these changes
Feb 5, 2026
andrewmwells-amazon
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #363
Description of changes: Nested datatypes are not (yet) allowed in Strata (and are also unsupported by SMT
declare_datatype). This adds error checking for such types, including with mutually recursive nesting.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.