Skip to content

Ondra add better logging for neighboring nets #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrej-lukas merged 2 commits into from
May 25, 2026
+3 −1
Merged

Ondra add better logging for neighboring nets #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc52d46
Align default port with the NSG
ondrej-lukas May 25, 2026
5ca4243
Add deprecation warning
ondrej-lukas May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion netsecgame/agents/base_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ def request_game_reset(

if __name__ == "__main__":
# Example usage of BaseAgent
GAME_PORT = 5000 # Change to the appropriate port
GAME_PORT = 9000 # Change to the appropriate port
agent = BaseAgent("localhost", GAME_PORT, AgentRole.Attacker)
# Register the agent
observation = agent.register()
Expand Down
2 changes: 2 additions & 0 deletions netsecgame/game/worlds/NetSecGame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,8 @@ def _create_state_from_view(self, view:dict, add_neighboring_nets:bool=True)->Ga
# Add all controlled hosts to known_hosts
known_hosts = known_hosts.union(controlled_hosts)
if add_neighboring_nets:
self.logger.info("Adding neighboring networks to the state.")
self.logger.warning("Using 'add_neighboring_nets=True' is deprecated and will be removed in future.")
# Extend the known networks with the neighbouring networks
# This is to solve in the env (and not in the agent) the problem
# of not knowing other networks appart from the one the agent is in
Expand Down
Loading