Add support for StreamARN in Kinesis reads#384
Open
kubukoz wants to merge 1 commit intostreamdal:masterfrom
Open
Add support for StreamARN in Kinesis reads#384kubukoz wants to merge 1 commit intostreamdal:masterfrom
kubukoz wants to merge 1 commit intostreamdal:masterfrom
Conversation
Author
|
Hi @blinktag, if you have the time I'd appreciate a look / some hints :) (especially on what to do with all the generated code) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to read another account's stream, and noticed Plumber wasn't liking it - went ahead and added some rudimentary support, for Kinesis specifically.
I had to upgrade the AWS SDK because it wasn't accepting StreamARN in GetShardIterator in the older versions. Also had to update counterfeiter as it didn't include the
aws-sdk-go/awsimport, necessary for the Context type to resolve.This is my first Go contribution ever, and the first one to this project too, so please let me know if anything can be improved, and whether I should split the dependency updates into a separate PR or commit :)