Skip to content

Add prometheus metics component and overlay#8

Merged
tomncooper merged 4 commits intomainfrom
prometheus
Mar 27, 2026
Merged

Add prometheus metics component and overlay#8
tomncooper merged 4 commits intomainfrom
prometheus

Conversation

@tomncooper
Copy link
Copy Markdown
Contributor

@tomncooper tomncooper commented Mar 23, 2026

This PR refactors the current deployment setup into a core kustomize component and creates a core overlay. It also adds a metrics component (that can be added to any overlay) and metrics overlay which is (core + metrics components).

This addressed #2.

* Refactor base install components into "core" kustomize component
* Add metrics kustomize component which installs prometheus operator,
  server and configures Kafka metrics and console
* Add core and metrics overlays
* Update install/uninstall scripts and README with new layout and
  overlay options (via OVERLAY env var)

Signed-off-by: Thomas Cooper <code@tomcooper.dev>
@tomncooper tomncooper changed the title Move current setup into "core" component and add "metrics" component and overlay Add prometheus metics component and overlay Mar 24, 2026
Copy link
Copy Markdown

@Frawless Frawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to keep in that that during #5 we could also use existing prometheus instance for metrics part.

Signed-off-by: Thomas Cooper <code@tomcooper.dev>
@tomncooper
Copy link
Copy Markdown
Contributor Author

@Frawless @kornys Thanks for your reviews. I started working on a refactor of the smoke tests to make adding overlays easier in future. However, it grew into a much bigger refactor and didn't want to add it into this one.

So I have just updated the smoke test setup to test the metrics overlay and will post the smoke test refactor as a separate PR.

@tomncooper tomncooper requested review from Frawless and kornys March 26, 2026 11:39
Copy link
Copy Markdown
Member

@kornys kornys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Thomas Cooper <code@tomcooper.dev>
Signed-off-by: Thomas Cooper <code@tomcooper.dev>
@tomncooper tomncooper merged commit 17ec06c into main Mar 27, 2026
7 checks passed
@Frawless Frawless deleted the prometheus branch March 27, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants