feat: Include asset name when logging asset-related issues#3202
Open
Eideren wants to merge 3 commits into
Open
feat: Include asset name when logging asset-related issues#3202Eideren wants to merge 3 commits into
Eideren wants to merge 3 commits into
Conversation
xen2
reviewed
Jun 3, 2026
| return $"{AssetReference.Location}({Line + 1},{Character + 1}): {base.Text}"; | ||
| return base.Text; | ||
| } | ||
| set |
Member
There was a problem hiding this comment.
Good change!
However I would rather avoid getter/setter discrepancy like this.
Few options:
Textstays as is, we add a virtualFormattedText(get-only).- In practice,
Textis only set internally, so we could keep the setter private and/or use a field. ThenTextbecomes get-only (basically acting as theFormattedTextmentioned before).
Collaborator
Author
There was a problem hiding this comment.
I didn't really like this change either, but wasn't comfortable changing public apis.
Removed the setter on Text - FormattedText has larger implications both on changing the 63 loc which reads from Text as well as what should or should not be formatted within
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
The different log display do not

ToString()log messages they receive, instead they extract theLogTypeandText, this PR ensures that theTextfor AssetLogMessage includes the asset location.The different logger omit certain information depending on the filters, so using
ToStringor introducing aToStringShort()andToStringLongdid not feel like the best way to go about solving this.Related Issue
None
Types of changes
Checklist