Fix V2 namespace singularization#2229
Closed
jar-stripe wants to merge 15 commits into
Closed
Conversation
…0d73c68b612253be5eadfcc065
Committed-By-Agent: claude
jar-stripe
force-pushed
the
jar/fix-v2-namespace-rename
branch
from
db0bcdd to
f97ad73
Compare
xavdid
approved these changes
Jun 3, 2026
stripe-openapi
Bot
force-pushed
the
latest-codegen-private-preview
branch
from
967f232 to
99eb64f
Compare
Base automatically changed from
latest-codegen-private-preview
to
private-preview
June 3, 2026 22:17
Member
|
As far as I can tell, all the changes in this PR are already captured in the auto PR; closing. I'll make sure this is reflected in the final java changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The codegen incorrectly singularized V2 namespace-promoted service names (
PaymentServiceinstead ofPaymentsService). This was a latent bug that only manifested when new V2 namespaces were added.What?
v2.PaymentServicetov2.PaymentsServiceSee Also
Changelog
v2.PaymentServicetov2.PaymentsServiceto more closely match our API naming