Fix V2 namespace singularization#1824
Merged
xavdid merged 1 commit intoJun 3, 2026
Merged
Conversation
Committed-By-Agent: claude
a2f3812 to
f122b04
Compare
xavdid
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The codegen incorrectly singularized V2 namespace-promoted service names (
PaymentServiceinstead ofPaymentsService). This was a latent bug that only manifested when new V2 namespaces were added.What?
v2.PaymentServicetov2.PaymentsServiceSee Also
Changelog
v2.PaymentServicetov2.PaymentsServiceto more closely match our API naming