Skip to content

Inital PoC#1776

Closed
mbroshi-stripe wants to merge 2 commits intobetafrom
mbroshi/batch_jobs
Closed

Inital PoC#1776
mbroshi-stripe wants to merge 2 commits intobetafrom
mbroshi/batch_jobs

Conversation

@mbroshi-stripe
Copy link
Copy Markdown
Contributor

Why?

What?

See Also

@mbroshi-stripe mbroshi-stripe requested a review from a team as a code owner January 29, 2026 22:26
@mbroshi-stripe mbroshi-stripe requested review from prathmesh-stripe and removed request for a team January 29, 2026 22:26
minhhoang0707

This comment was marked as off-topic.

@mbroshi-stripe mbroshi-stripe marked this pull request as draft March 19, 2026 13:41
@mbroshi-stripe mbroshi-stripe removed the request for review from prathmesh-stripe March 19, 2026 13:41
@mbroshi-stripe mbroshi-stripe changed the base branch from beta to latest-codegen-beta March 23, 2026 22:02
Base automatically changed from latest-codegen-beta to beta March 23, 2026 23:13
# Has the value `true` if the object exists in live mode or the value `false` if the object exists in test mode.
attr_reader :livemode

ENDPOINT_PATH_V1_ACCOUNT_UPDATE = "/v1/accounts/:account"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where and how will these be used?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this:

batch = client.v2.core.batch_jobs.create(
    endpoint: {
      http_method: 'post',
      path: Stripe::V2::Core::BatchJob::ENDPOINT_PATH_V1_CUSTOMER_UPDATE
    },
    skip_validation: true,
    metadata: {}
  )

Let me know if you know of a better way to handle that!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it's important to use constants is that sadly the actual substring :account in /v1/accounts/:account matters. I want to nudge users as best I can to use these blessed strings.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. I was confused because the generated test didn't use it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good point. I'll investigate if there's a way I can use those constants in generated examples.

@mbroshi-stripe mbroshi-stripe deleted the mbroshi/batch_jobs branch March 25, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants