Add support for nvim servers running over TCP#77
Open
adamnew123456 wants to merge 1 commit intosubnut:mainfrom
Open
Add support for nvim servers running over TCP#77adamnew123456 wants to merge 1 commit intosubnut:mainfrom
adamnew123456 wants to merge 1 commit intosubnut:mainfrom
Conversation
pynvim supports this, we just have to perform the right invocation depending upon the format of the address. nvim itself does this in a straightforward way so we can do the same thing for consistency. https://github.com/neovim/neovim/blob/d9d8c660fd5559d928c8870a21970a375674e310/src/nvim/event/socket.c#L46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pynvim natively supports four methods for attaching to nvim:
childandstdioaren't really relevant for nvim-ghost since it runs the WebSocket server as a daemon, and separate nvim instances share it by sending focus messages. Currently the helper script assumessocket, buttcpis also an option (I use it to make my config more cross-platform).The only trick is that you have to guess which transport is intended by parsing
$NVIM. But nvim also does this when it interprets the user's--listenconfig, I just borrowed the algorithm:https://github.com/neovim/neovim/blob/d9d8c660fd5559d928c8870a21970a375674e310/src/nvim/event/socket.c#L46