[all] change Gateway support by configuring multi httproutes#276
Open
DanielRaapDev wants to merge 8 commits into
Open
[all] change Gateway support by configuring multi httproutes#276DanielRaapDev wants to merge 8 commits into
DanielRaapDev wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates multiple Helm charts to support configuring multiple Gateway API HTTPRoute resources via a new httpRoutes map, replacing the previous single httpRoute (and extraHttpRoutes where present). This is intended to allow defining multiple distinct routes per chart instance.
Changes:
- Replace
httpRoute/extraHttpRoutesvalues with a newhttpRoutesmap in chart values. - Update
templates/httproute.yamlto render oneHTTPRouteper entry inhttpRoutes. - Update Helm unittest fixtures to validate multiple rendered
HTTPRoutedocuments and updateartifacthub.io/changesnotes.
Reviewed changes
Copilot reviewed 93 out of 93 changed files in this pull request and generated 36 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/sophora-youtube-connector/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-youtube-connector/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-youtube-connector/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-youtube-connector/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-youtube-connector/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-webclient/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-webclient/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-webclient/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-webclient/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-webclient/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-ugc/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-ugc/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-ugc/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-ugc/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-ugc/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-server/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-server/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-server/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-server/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-server/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-seo-check/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-seo-check/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-seo-check/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-schema-docs/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-schema-docs/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-schema-docs/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-schema-docs/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-schema-docs/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-metadata-supplier/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-metadata-supplier/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-metadata-supplier/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-metadata-supplier/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-metadata-supplier/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-media-finder/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-media-finder/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-media-finder/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-media-finder/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-media-finder/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-linkchecker/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-linkchecker/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-linkchecker/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-linkchecker/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-linkchecker/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-indexing-service/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-indexing-service/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-indexing-service/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-indexing-service/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-indexing-service/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-importer/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-importer/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-importer/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-importer/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-importer/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-image-ai/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-image-ai/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-image-ai/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-image-ai/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-image-ai/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-image-access-service/values.yaml | Replace httpRoute + extraHttpRoutes with httpRoutes map. |
| charts/sophora-image-access-service/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-image-access-service/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-image-access-service/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-image-access-service/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-contentapi/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-contentapi/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-contentapi/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-contentapi/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-contentapi/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-ai/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-ai/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-ai/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-ai/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-ai/Chart.yaml | Bump chart version + document breaking change. |
| charts/sophora-admin-dashboard/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/sophora-admin-dashboard/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/sophora-admin-dashboard/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/sophora-admin-dashboard/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/sophora-admin-dashboard/Chart.yaml | Bump chart version + document breaking change. |
| charts/planr-tools/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/planr-tools/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/planr-tools/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/planr-tools/templates/httproute.yaml | Render HTTPRoutes from httpRoutes and adjust rule generation. |
| charts/planr-tools/Chart.yaml | Bump chart version + document breaking change. |
| charts/o-neko/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/o-neko/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/o-neko/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/o-neko/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/o-neko/Chart.yaml | Bump chart version + document breaking change. |
| charts/o-neko-catnip/values.yaml | Replace single httpRoute config with httpRoutes map. |
| charts/o-neko-catnip/tests/values/httproute.yaml | Update test values to the new httpRoutes schema. |
| charts/o-neko-catnip/tests/httproute_test.yaml | Update unittest to assert multiple HTTPRoute documents. |
| charts/o-neko-catnip/templates/httproute.yaml | Render HTTPRoutes from httpRoutes. |
| charts/o-neko-catnip/Chart.yaml | Bump chart version + document breaking change. |
Comments suppressed due to low confidence (1)
charts/planr-tools/templates/httproute.yaml:40
filters:is always rendered for each rule. When neither the URLRewrite filter (path == "/") nor$httpRoute.filtersare present, this producesfilters: null, which can violate the Gateway API schema (filters should be omitted or an array, not null). Wrap thefilters:block in a conditional so it’s only emitted when there is at least one filter.
filters:
{{- if ne $component.exposure.path "/" }}
{{/* Strip the path prefix so apps receive requests at their own root, same as the Ingress rewrite. */}}
- type: URLRewrite
urlRewrite:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+8
| {{- range $key, $httpRoute := .Values.httpRoutes }} | ||
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: HTTPRoute | ||
| metadata: | ||
| name: {{ $fullName }} | ||
| name: {{ $fullName }}-{{ $key }} |
Comment on lines
+4
to
+8
| {{- range $key, $httpRoute := .Values.httpRoutes }} | ||
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: HTTPRoute | ||
| metadata: | ||
| name: {{ $fullName }} | ||
| name: {{ $fullName }}-{{ $key }} |
Comment on lines
+4
to
+8
| {{- range $key, $httpRoute := .Values.httpRoutes }} | ||
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: HTTPRoute | ||
| metadata: | ||
| name: {{ $fullName }} | ||
| name: {{ $fullName }}-{{ $key }} |
Comment on lines
+4
to
+8
| {{- range $key, $httpRoute := .Values.httpRoutes }} | ||
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: HTTPRoute | ||
| metadata: | ||
| name: {{ $fullName }} | ||
| labels: {{ include "sophora-server.topLevelLabels" . | nindent 4 }} | ||
| {{- with .Values.httpRoute.annotations }} | ||
| name: {{ $fullName }}-{{ $key }} |
Comment on lines
+4
to
+8
| {{- range $key, $httpRoute := .Values.httpRoutes }} | ||
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: HTTPRoute | ||
| metadata: | ||
| name: {{ $fullName }} | ||
| name: {{ $fullName }}-{{ $key }} |
| description: Sophora AI | ||
| type: application | ||
| version: 2.3.0 | ||
| version: 2.4.0 |
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 1.6.0 | ||
| version: 1.7.0 |
| description: A Helm chart for deploying the planr-tools applications | ||
| type: application | ||
| version: 1.0.0 | ||
| version: 1.1.0 |
| description: A Helm chart for O-Neko | ||
| type: application | ||
| version: 2.1.0 | ||
| version: 2.2.0 |
| description: A Helm chart for the O-Neko URL trigger | ||
| type: application | ||
| version: 1.4.0 | ||
| version: 1.5.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPRoute configuration changed to support a map of routes.
The previous httpRoute and extraHttpRoutes fields have been removed in favor of the new httpRoutes[] filed (breaking change)!
SUDO-701