-
Notifications
You must be signed in to change notification settings - Fork 17
feat: remove generated protobuf code from substrait-python #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ddbeb80
257a13d
7f0ffbc
4b88cb3
fda7dd5
01e574d
b9e6132
783de17
53eb3fd
8259dc1
1146bb4
7d286b6
de11be4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -eou pipefail | ||
|
|
||
| submodule_dir=./third_party/substrait | ||
| extension_dir=./src/substrait/extension_files | ||
|
|
||
| # Remove the old extension files | ||
| rm -rf "$extension_dir" | ||
|
|
||
| # Copy over new yaml files | ||
| cp -fr "$submodule_dir"/extensions "$extension_dir" | ||
| find "$extension_dir" -type f -exec chmod u+rw {} + | ||
|
|
||
| # Ensure there's an __init__.py file in the extension directory | ||
| touch $extension_dir/__init__.py |
This file was deleted.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,10 @@ authors = [{name = "Substrait contributors", email = "substrait@googlegroups.com | |
| license = {text = "Apache-2.0"} | ||
| readme = "README.md" | ||
| requires-python = ">=3.10,<3.14" | ||
| dependencies = ["protobuf >=5,<7"] | ||
| dependencies = [ | ||
| "protobuf >=5,<7", | ||
| "substrait-protobuf==0.79.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll open a separate issue to eventually change this to a range of versions and come up with a way to test multiple versions in ci. |
||
| ] | ||
| dynamic = ["version"] | ||
|
|
||
| [tool.setuptools_scm] | ||
|
|
@@ -53,11 +56,11 @@ update-substrait = [ { task = "update-submodule" }, { task = "codegen" }] | |
|
|
||
| update-submodule = "./update_submodule.sh" | ||
|
|
||
| codegen = [{ task = "antlr" }, { task = "codegen-proto" }, { task = "codegen-extensions" }] | ||
| codegen = [{ task = "antlr" }, { task = "copy-extensions" }, { task = "codegen-extensions" }] | ||
|
|
||
| check-codegen = "./check_codegen.sh" | ||
|
|
||
| codegen-proto = "./gen_proto.sh" | ||
vbarua marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| copy-extensions = "./copy_extension_yamls.sh" | ||
|
|
||
| antlr = """ | ||
| cd third_party/substrait/grammar \ | ||
|
|
||
This file was deleted.
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I moved all of the extension files to a different dedicated directory, to avoid a conflict with the |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.