⬆️(back) update back and front dependencies#383
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
WalkthroughThis PR updates frontend dependencies and configurations. It adds Yarn resolution entries for picomatch across multiple dependency paths in the root frontend package.json, upgrades the lodash dependency from 4.17.23 to 4.18.1 in the conversations app, updates the Next.js TypeScript include path in conversations tsconfig.json, and documents these changes in the changelog. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CHANGELOG.md`:
- Around line 11-14: Under the Unreleased section, change the heading "##
Changed" to "### Changed" and convert the plain line "⬆️(back) update backend
dependencies" into a bullet list item (prefix with "- ") so it matches the
existing changelog structure; update the "Changed" heading and the entry text
accordingly to maintain consistent heading level and list formatting.
In `@src/backend/chat/models.py`:
- Line 174: Fix the typo in the Attachment model docstring by changing the field
description for `uploaded_by` from "usqser" to "user" in
src/backend/chat/models.py; locate the Attachment class or the docstring that
documents `uploaded_by` and update the text to read "`uploaded_by`: The user who
uploaded the attachment." to correct the spelling.
In `@src/frontend/apps/conversations/next-env.d.ts`:
- Line 3: tsconfig.json's "include" currently references ".next/types/**/*.ts"
which doesn't match next-env.d.ts importing "./.next/dev/types/routes.d.ts";
update the tsconfig.json include array to reference the actual generated path
(for example add or replace with "./.next/dev/types/**/*.d.ts" or
"./.next/dev/types/**/*.ts") so the compiler picks up the Next.js-generated
types; ensure the change targets the "include" entry in tsconfig.json and that
next-env.d.ts's import remains unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 21f95b86-0610-4ecd-acf1-dcfcbe3a1556
⛔ Files ignored due to path filters (1)
src/backend/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
CHANGELOG.mdsrc/backend/chat/models.pysrc/backend/pyproject.tomlsrc/frontend/apps/conversations/next-env.d.ts
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
| import "./.next/types/routes.d.ts"; | ||
| import "./.next/dev/types/routes.d.ts"; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify current Next.js generated type path usage in this app
rg -n --type=ts --type-add 'json:*.json' -g 'src/frontend/apps/conversations/**' \
'next-env\.d\.ts|\.next/dev/types|\.next/types'
# Inspect tsconfig include block for this app
fd -a 'tsconfig.json' src/frontend/apps/conversations -x sed -n '1,120p' {}Repository: suitenumerique/conversations
Length of output: 1016
🏁 Script executed:
# Search for any other references to .next/types or .next/dev/types in the repo
rg '\.next/(types|dev/types)' src/frontend/apps/conversations --type=ts --type=json --type=jsRepository: suitenumerique/conversations
Length of output: 229
Update tsconfig.json to align with Next.js-generated type path.
The next-env.d.ts file imports from ./.next/dev/types/routes.d.ts, but tsconfig.json still includes .next/types/**/*.ts on line 30. Update the include to match the actual generated path to maintain consistency and prevent type-checking drift:
- ".next/types/**/*.ts"
+ ".next/dev/types/**/*.ts"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/frontend/apps/conversations/next-env.d.ts` at line 3, tsconfig.json's
"include" currently references ".next/types/**/*.ts" which doesn't match
next-env.d.ts importing "./.next/dev/types/routes.d.ts"; update the
tsconfig.json include array to reference the actual generated path (for example
add or replace with "./.next/dev/types/**/*.d.ts" or
"./.next/dev/types/**/*.ts") so the compiler picks up the Next.js-generated
types; ensure the change targets the "include" entry in tsconfig.json and that
next-env.d.ts's import remains unchanged.
There was a problem hiding this comment.
@maxenceh, compris — si le changement dans next-env.d.ts est revert (retour à ./.next/types/routes.d.ts), ma suggestion de mise à jour du tsconfig.json devient caduque. Vous pouvez ignorer ce commentaire.
There was a problem hiding this comment.
@maxenceh nope, c'est un fichier auto-généré par next. Faut maj tsconfig (je viens de le faire)
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
providenz
force-pushed
the
providenz/update-deps
branch
from
cabab7d to
b79c61d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/frontend/package.json`:
- Around line 41-45: Update the transitive picomatch resolutions from "2.3.2" to
"4.0.4" by replacing the resolution entries "**/anymatch/picomatch",
"**/readdirp/picomatch", "**/jest-util/picomatch", and "**/micromatch/picomatch"
in package.json so that the lockfile and installs resolve picomatch v4.0.4;
after editing run your package manager's install/lockfile update (npm install or
yarn install / npm ci as appropriate) and verify the resulting lockfile shows
picomatch@4.0.4 for those dependency paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 831611cb-11cc-4e4c-887f-2e4d04b8267c
⛔ Files ignored due to path filters (2)
src/backend/uv.lockis excluded by!**/*.locksrc/frontend/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
CHANGELOG.mdsrc/backend/chat/models.pysrc/backend/pyproject.tomlsrc/frontend/apps/conversations/next-env.d.tssrc/frontend/package.json
✅ Files skipped from review due to trivial changes (3)
- CHANGELOG.md
- src/backend/chat/models.py
- src/backend/pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (1)
- src/frontend/apps/conversations/next-env.d.ts
providenz
force-pushed
the
providenz/update-deps
branch
3 times, most recently
from
0b909a2 to
b4ceeb6
Compare
providenz
changed the title
maxenceh
changed the title
providenz
force-pushed
the
providenz/update-deps
branch
2 times, most recently
from
71dd0ab to
7c1501c
Compare
providenz
force-pushed
the
providenz/update-deps
branch
from
7c1501c to
73658c1
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/backend/pyproject.toml`:
- Line 20: Update the hardcoded certifi path in the Helm values and example
files to match the new Python version: replace occurrences of
"/usr/local/lib/python3.12/site-packages/certifi/cacert.pem" with
"/usr/local/lib/python3.13/site-packages/certifi/cacert.pem" in the templates
referenced (specifically in the values file templates named
dev-staging/values.conversations.yaml.gotmpl and
docs/examples/conversations.values.yaml); ensure any other Helm values or
templates that reference "python3.12" are similarly updated to "python3.13" so
the mountPath matches the container image declared in pyproject.toml and
Dockerfiles.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f9853015-eb38-44ed-96f8-b1e45b0b0bac
⛔ Files ignored due to path filters (2)
src/backend/uv.lockis excluded by!**/*.locksrc/frontend/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
CHANGELOG.mdsrc/backend/pyproject.tomlsrc/frontend/apps/conversations/package.jsonsrc/frontend/apps/conversations/tsconfig.jsonsrc/frontend/package.json
✅ Files skipped from review due to trivial changes (4)
- src/frontend/apps/conversations/package.json
- src/frontend/apps/conversations/tsconfig.json
- CHANGELOG.md
- src/frontend/package.json
| "Natural Language :: English", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Candidate CI/container config files =="
fd -i 'dockerfile|compose|\.ya?ml$|\.toml$'
echo
echo "== Python version declarations =="
fd -i 'dockerfile|compose|\.ya?ml$|\.toml$' \
-x rg -n --no-heading -e 'python-version' -e 'FROM[[:space:]]+python:' -e 'PYTHON_VERSION' -e '3\.12|3\.13' {}Repository: suitenumerique/conversations
Length of output: 1760
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Files containing python3.12 references =="
rg -l 'python3\.12' --type yaml --type dockerfile
echo
echo "== Context around python3.12 references (max 2 lines before/after) =="
rg -B2 -A2 'python3\.12' --type yaml --type dockerfileRepository: suitenumerique/conversations
Length of output: 168
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Files containing python3.12 references =="
rg -l 'python3\.12'
echo
echo "== Context around python3.12 references =="
rg -B2 -A2 'python3\.12'Repository: suitenumerique/conversations
Length of output: 1047
Update Helm values files to reference Python 3.13 paths instead of 3.12.
The pyproject.toml and Dockerfiles now declare Python 3.13, but the Helm values files still reference hardcoded Python 3.12 paths:
src/helm/env.d/dev-staging/values.conversations.yaml.gotmpldocs/examples/conversations.values.yaml
Both contain mountPath: /usr/local/lib/python3.12/site-packages/certifi/cacert.pem, which will not exist in the 3.13 container at runtime. Update these to use python3.13 in the path.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/backend/pyproject.toml` at line 20, Update the hardcoded certifi path in
the Helm values and example files to match the new Python version: replace
occurrences of "/usr/local/lib/python3.12/site-packages/certifi/cacert.pem" with
"/usr/local/lib/python3.13/site-packages/certifi/cacert.pem" in the templates
referenced (specifically in the values file templates named
dev-staging/values.conversations.yaml.gotmpl and
docs/examples/conversations.values.yaml); ensure any other Helm values or
templates that reference "python3.12" are similarly updated to "python3.13" so
the mountPath matches the container image declared in pyproject.toml and
Dockerfiles.
73658c1 to
a483b24
Compare
Signed-off-by: Laurent Paoletti <lp@providenz.fr>
providenz
force-pushed
the
providenz/update-deps
branch
from
a483b24 to
4f60017
Compare
|
2 participants
Purpose
Update dependencies
Summary by CodeRabbit
Release Notes