Closed
Conversation
AntoLC
added
dependencies
AntoLC
force-pushed
the
packages/common-package
branch
from
a8d2be9 to
470be53
Compare
Create the Docs package in the monorepo. This package will contain all the features, components or utilities that are common across the "frontend" ecosystem.
Move the Divider custom block to the common package. It will be needed in multiple places, Docs app and the y-provider server.
AntoLC
force-pushed
the
packages/common-package
branch
from
470be53 to
c3d2779
Compare
Member
|
This will allow supporting custom blocks in #1213 (comment) ! |
Member
|
@AntoLC what about the CallOuts ? |
Collaborator
Author
|
Does not seem to be in the priority, better to close it for now, we can still reopen it if the priority change. We can find it easily thanks to https://github.com/suitenumerique/docs/issues?q=label%3A%22keep%20track%22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We are starting to need features, types, and others in multiple places in the repo.
To do so, we are creating the Docs package, this package will contain all the features, components or utilities that are common across the "frontend" ecosystem.
Proposal