update tidb parser

[sunary]

Summary by CodeRabbit

• Refactor

  • Updated import paths to use the latest PingCAP TiDB parser packages throughout the project.
  • Simplified map copying in table mapping logic for improved code clarity.
  • Refactored conditional statements to switch-case for better readability in tests and migration logic.

• Chores

  • Upgraded Go module version and refreshed dependencies to newer versions.
  • Removed unused variables from tests for cleaner code.

• Bug Fixes

  • Adjusted SQL output for default column values to ensure correct formatting of default value options.

[coderabbitai]

Walkthrough

The changes update import paths throughout the codebase from github.com/pingcap/parser to github.com/pingcap/tidb/pkg/parser, reflecting a dependency migration. Several files refactor field accesses to use accessor methods from the new parser version. Some control flow is modernized (e.g., using switch statements), and Go module dependencies are updated. Minor code simplifications and cleanups are also included.

Changes

Cohort / File(s)	Change Summary
PingCAP parser import migration element/column.go, element/index.go, element/migration.go, element/table.go, export/avro/builder.go, sql-parser/mysql.go, sql-parser/postgresql.go, sql-parser/sqlite.go, sqlize.go	Updated import paths from github.com/pingcap/parser/... to github.com/pingcap/tidb/pkg/parser/... for ast, format, model, mysql, types, and test_driver packages. Adjusted code to use new accessor methods where required.
Field/type refactor for new parser element/column.go, export/avro/builder.go	Replaced direct field accesses on MySQL type info with corresponding getter methods (GetType(), GetElems(), GetFlen(), GetDecimal()).
Index type update element/index.go, sql-parser/mysql.go	Changed IndexType field in Index struct from model.IndexType to ast.IndexType. Updated references to index type constants to use ast.IndexTypeBtree.
Control flow modernization element/table.go, sqlize_test.go	Refactored if-else chains into switch statements for clarity and maintainability. No logic changes.
Map copy simplification sql-builder/builder.go	Replaced manual map copying with maps.Copy() from the standard library, simplifying the MappingTables method.
Go module and dependency updates go.mod	Updated Go version to 1.24.1, migrated parser dependency, and upgraded several indirect dependencies.
Test cleanup sqlize_test.go	Removed unused global variables related to SQL statements.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

Oh, what a hop through parser fields anew,
Imports now tidily point to tidb’s view.
Switches replace the ifs, so neat,
Maps copy swiftly—what a treat!
Dependencies fresh, the garden’s in bloom,
CodeRabbit’s review will finish soon!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03c362e and 045c3a3.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (12)

• element/column.go (3 hunks)
• element/index.go (1 hunks)
• element/migration.go (1 hunks)
• element/table.go (2 hunks)
• export/avro/builder.go (3 hunks)
• go.mod (2 hunks)
• sql-builder/builder.go (2 hunks)
• sql-parser/mysql.go (3 hunks)
• sql-parser/postgresql.go (1 hunks)
• sql-parser/sqlite.go (1 hunks)
• sqlize.go (1 hunks)
• sqlize_test.go (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

element/index.go (1)

element/node.go (1)

• Node (22-26)

sqlize_test.go (1)

utils/file.go (1)

• PathDoesNotExistErr (13-13)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

🔇 Additional comments (22)

sql-builder/builder.go (2)

6-6: LGTM: Good use of standard library.

Adding the maps import to utilize maps.Copy() is a modern and idiomatic approach.

---

113-113: Excellent refactoring using standard library.

Replacing the manual map copying loop with maps.Copy(s.tables, m) is more concise and idiomatic. This leverages the Go 1.21+ standard library function for better code clarity.

sql-parser/sqlite.go (1)

6-6: LGTM: Import path updated for TiDB parser migration.

The import path change from github.com/pingcap/parser/ast to github.com/pingcap/tidb/pkg/parser/ast aligns with the dependency migration objectives.

element/migration.go (1)

8-8: LGTM: Consistent import path migration.

The import path update to github.com/pingcap/tidb/pkg/parser/ast is consistent with the TiDB parser migration across the codebase.

sql-parser/postgresql.go (1)

9-9: LGTM: Import path consistently updated.

The import path change to github.com/pingcap/tidb/pkg/parser/ast maintains consistency with the TiDB parser migration throughout the project.

sqlize.go (1)

9-9: LGTM: Test driver import path updated.

The import path change to github.com/pingcap/tidb/pkg/parser/test_driver completes the TiDB parser migration for the test driver component.

element/index.go (2)

9-9: LGTM: Import path successfully updated to TiDB parser.

The import path has been correctly updated from the legacy PingCAP parser to the new TiDB parser package, which aligns with the broader migration across the codebase.

---

16-16: LGTM: Type reference correctly updated to ast.IndexType.

The IndexType field type has been properly updated from model.IndexType to ast.IndexType to match the new import structure. This change is consistent with similar updates in sql-parser/mysql.go where model.IndexTypeBtree was replaced with ast.IndexTypeBtree.

go.mod (2)

3-3: Verify the significant Go version upgrade impact.

The Go version has been updated from 1.19 to 1.24.1, which is a substantial jump. Please ensure that this version bump doesn't introduce compatibility issues with other dependencies or deployment environments.

---

7-7: Go.mod Update: TiDB Parser Pseudo-Version Verified

• The pseudo-version v0.0.0-20250728085548-73284c42b94f on line 7 corresponds exactly to commit 73284c42b94f, with committer date 2025-07-28T08:55:48Z.
• There is no dedicated tag for pkg/parser, so using a pseudo-version is expected.
• You’re good to merge as-is. When the next official parser release is tagged (e.g. alongside v8.5.x or v9.0.x), consider updating this requirement to that stable version.

sql-parser/mysql.go (2)

4-5: LGTM: Import paths successfully updated to TiDB parser.

The import paths have been correctly updated from the legacy PingCAP parser to the new TiDB parser package, maintaining consistency with the broader codebase migration.

---

180-180: LGTM: Type references correctly updated to ast.IndexTypeBtree.

The references to model.IndexTypeBtree have been properly updated to ast.IndexTypeBtree to match the new import structure. This change is consistent with the type updates in element/index.go where model.IndexType was replaced with ast.IndexType.

Also applies to: 196-196

sqlize_test.go (2)

404-413: LGTM: Improved control flow with switch statement.

The refactoring from if-else to switch statement improves code readability and maintainability while preserving the exact same logic for handling migration folder paths.

---

427-436: LGTM: Consistent switch statement refactoring.

The second if-else block has been consistently refactored to use a switch statement, maintaining the same logic while improving code clarity and consistency with the previous change.

export/avro/builder.go (3)

7-8: LGTM: Import paths successfully updated to TiDB parser.

The import paths have been correctly updated from the legacy PingCAP parser to the new TiDB parser package, maintaining consistency with the broader codebase migration.

---

62-62: LGTM: Direct field access replaced with getter method.

The direct field access Elems has been properly replaced with the getter method GetElems(), which aligns with the encapsulated API design of the new parser package.

---

74-74: LGTM: Field accesses replaced with getter methods.

The direct field accesses Flen and Decimal have been correctly replaced with their respective getter methods GetFlen() and GetDecimal(), following the updated API pattern in the new parser package.

element/table.go (2)

11-12: Import path migration looks correct.

The update from github.com/pingcap/parser to github.com/pingcap/tidb/pkg/parser aligns with the TiDB parser package restructuring.

---

452-459: Good refactoring to switch statement.

The conversion from if-else chain to switch statement improves readability and maintainability. The logic remains functionally equivalent:

• MigrateAddAction is handled in its own case
• MigrateModifyAction and MigrateRenameAction are grouped together with the same logic (temporarily setting action to MigrateAddAction)

element/column.go (3)

12-14: Import path migration is consistent.

The import path updates match the changes in table.go and properly reflect the TiDB parser package restructuring.

---

45-45: Correct accessor method usage.

The change from direct field access (Tp) to method call (GetType()) aligns with the new TiDB parser API that uses accessor methods instead of direct field access.

---

247-251: String replacement logic is valid and isolated

No other occurrences of _UTF8MB4 were found in the Go codebase. This replacement is specifically scoped to the ColumnOptionDefaultValue formatter to strip MySQL’s default‐value encoding prefix (_UTF8MB4) from string literals. It is necessary to maintain the expected SQL output and will not impact any other functionality.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch update-tidb-parser

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.