Remove <linux/synclink.h> ioctls because the synclink_gt driver is being removed from the kernel#185
Open
EthanNelson-Moore wants to merge 1 commit into
Conversation
The synclink_gt driver is being removed from the kernel due to long-unfixed code style and correctness issues and a lack of known users. <linux/synclink.h> will be removed along with it. To allow this crate to continue compiling, remove the code to generate ioctl bindings for this header. Also remove the generated ioctl values, since they will no longer function.
klarasm
pushed a commit
to klarasm/linux
that referenced
this pull request
May 12, 2026
The synclink_gt driver was marked as broken in commit 426263d ("tty: synclink_gt: mark as BROKEN") in July 2023 because it had severe structural problems and there had been no evidence of users since 2016. Since then, no meaningful improvements have been made to the driver, and it is unlikely that will ever happen due to the lack of interest. Drop the driver and references to it in comments and documentation. include/uapi/linux/synclink.h is also removed. The only use of this header I have found is the linux-raw-sys Rust crate. It generates bindings for all UAPI headers, but has a hardcoded list of headers and ioctls, including this one, so that does not indicate that anyone is using it. I have sent a pull request to remove the include and ioctl definitions for this header (see the link below). Link: sunfishcode/linux-raw-sys#185 Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com> Acked-by: Jakub Kicinski <kuba@kernel.org> Link: https://patch.msgid.link/20260504031519.18877-1-enelsonmoore@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synclink_gt driver is being removed from the kernel due to long-unfixed code style and correctness issues and a lack of known users.
<linux/synclink.h>will be removed along with it. To allow this crate to continue compiling, remove the code to generate ioctl bindings for this header. Also remove the generated ioctl values, since they will no longer function.