fix: clarify error message when starting docker container#4790
fix: clarify error message when starting docker container#4790unlair wants to merge 1 commit intosupabase:developfrom
Conversation
3c3b4c0 to
42266b4
Compare
Pull Request Test Coverage Report for Build 21680522717Details
💛 - Coveralls |
42266b4 to
97f8bfd
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Cache: Disabled due to Reviews > Disable Cache setting Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe DockerStart function's error handling was modified to include the container name in the wrapped error message. The format string changed from "failed to start docker container: %w" to "failed to start docker container %q: %w", containerName, err. No other logic, control flow, or public signatures were changed. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Error message was not indicating which Docker container failed to start, forcing the user to use a process of elimination to narrow down the problem.
97f8bfd to
ab6464d
Compare
Error message was not indicating which Docker container failed to start, forcing the user to use a process of elimination to narrow down the problem.
What kind of change does this PR introduce?
Bug fix (updating error message).
What is the current behavior?
When an error is returned when starting a Docker container (e.g. #3593 the error message reads:
failed to start docker container: <some error>What is the new behavior?
The error message reads:
failed to start docker container "<container name>": <some error>