Open
Conversation
superdoc-bot
bot
added
review: thorough
review: quick
and removed
review: thorough
labels
artem-harbour
force-pushed
the
artem/uidisplayfallbackfont
branch
from
93c33ea to
68aa9c7
Compare
artem-harbour
force-pushed
the
artem/uidisplayfallbackfont
branch
from
68aa9c7 to
e86dc92
Compare
caio-pizzol
reviewed
Apr 3, 2026
Contributor
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@artem-harbour approach looks good, just a couple of small things: the warning message wording and telling users what to use instead. also consider using the existing warnOnce() helper. left inline comments.
|
|
||
| if (hasConfiguredUiDisplayFallbackFont) { | ||
| console.warn('[SuperDoc] config.uiDisplayFallbackFont is going to be deprecated and removed in future releases'); | ||
| } |
Contributor
There was a problem hiding this comment.
we already have a warnOnce() helper in src/helpers/deprecation.js that prevents the same warning from showing multiple times. worth using here instead of console.warn?
|
|
||
| if (hasConfiguredUiDisplayFallbackFont) { | ||
| console.warn('[SuperDoc] config.uiDisplayFallbackFont is going to be deprecated and removed in future releases'); | ||
| } |
Contributor
There was a problem hiding this comment.
two things on the message: "is going to be deprecated" should be "is deprecated" to match the rest of the codebase, and it should tell the user what to use instead.
Suggested change
| } | |
| console.warn('[SuperDoc] config.uiDisplayFallbackFont is deprecated and will be removed in a future version. Use createTheme({ font: \'...\' }) or the --sd-ui-font-family CSS variable instead.'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.