fix: disable sdt hover in view mode for web layout#2661
Conversation
VladaHarbour
force-pushed
the
sd-2414_disable-sdt-hover-web
branch
from
be9993f to
1be4147
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour tested with Word docs in web layout viewing mode — hover suppression and inline click blocking work nicely.
two small things: (1) clicking a block SDT in viewing mode still shows a blue selection outline in web layout. (2) when the document only contains a block SDT with nothing around it, the cursor stays inside instead of moving out on mode switch. both are minor since the CSS hides the hover, but worth a look.
pushed two behavior tests for click suppression in viewing mode. left inline comments. feel free to merge after addressing those.
...ges/super-editor/src/editors/v1/core/helpers/getViewModeSelectionWithoutStructuredContent.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/editors/v1/extensions/structured-content/StructuredContentViewBase.js
Show resolved
Hide resolved
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
lgtm (after addressing comments)
VladaHarbour
force-pushed
the
sd-2414_disable-sdt-hover-web
branch
from
fe0a102 to
2e26333
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour both fixes look good, tests cover the edge cases. approving.
|
🎉 This PR is included in vscode-ext v1.1.0-next.61 |
|
🎉 This PR is included in template-builder v1.3.0-next.18 The release is available on GitHub release |
|
🎉 This PR is included in esign v2.2.0-next.19 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/react v1.0.0-next.15 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.24.0-next.58 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.5.0-next.58 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.3.0-next.59 |
3 participants
No description provided.