fix: change default line height for header/footer editor#2672
fix: change default line height for header/footer editor#2672caio-pizzol merged 3 commits intomainfrom
Conversation
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour looks good — fixes the clipping and the value is correct per the spec. Tested locally, all header lines show up fine. Pushed a commit with 4 behavior tests. One small note inline, nothing blocking.
packages/super-editor/src/editors/v1/core/renderers/ProseMirrorRenderer.ts
Outdated
Show resolved
Hide resolved
Verify that header/footer editors use lineHeight 1 (matching OOXML Header style w:line="240"), body editors retain the default 1.2, and header content is not clipped when entering edit mode.
VladaHarbour
force-pushed
the
sd-2235_header-line-height
branch
from
3b4f830 to
f523b99
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour looks good, last round's feedback is addressed. approving.
|
🎉 This PR is included in vscode-ext v1.1.0-next.64 |
|
🎉 This PR is included in @superdoc-dev/react v1.0.0-next.18 The release is available on GitHub release |
|
🎉 This PR is included in esign v2.2.0-next.22 The release is available on GitHub release |
|
🎉 This PR is included in template-builder v1.3.0-next.21 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.5.0-next.61 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.24.0-next.61 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.3.0-next.62 |
2 participants
It seems that lineHeight multiplier is not applied neither to header rendered with layout engine nor to header in Word. Removing multiplier which is applied to ProseMirror editor we still use for header/footer editing seems to be the most efficient and quick fix