refactor(consumer-typecheck): consolidate 3 snapshot scripts into one CLI (SD-3213b)#3403
Open
caio-pizzol wants to merge 1 commit into
Open
refactor(consumer-typecheck): consolidate 3 snapshot scripts into one CLI (SD-3213b)#3403caio-pizzol wants to merge 1 commit into
caio-pizzol wants to merge 1 commit into
Conversation
… CLI (SD-3213b)
Three standalone snapshot scripts (super-editor-package, legacy
subpaths, root 4-source inventory) shared no code but had identical
CLI boilerplate and three separate CI step blocks. Consolidate into a
single CLI with a family-module pattern.
- tests/consumer-typecheck/snapshot.mjs is the unified entry point.
Dispatches on --all or --family <name>, with --check (default) or
--write. Aggregates exit codes for --all.
- Each family module under tests/consumer-typecheck/snapshot/ exports
FAMILY, DESCRIPTION, and run({ mode }) -> { code }. No shared
abstraction; each family keeps its own enumeration and snapshot
shape.
- ci-superdoc.yml, release-superdoc.yml, release-stable.yml collapse
two step blocks into one snapshot.mjs --all --check call.
- CONTRIBUTING.md, snapshots/README.md, deep-type-audit.README.md,
packages/superdoc/AGENTS.md updated to reference the unified CLI.
Verified locally: all three families pass --check against committed
snapshots, both individually and via --all.
Contributor
Agent docs auditFound deterministic findings on 1 changed agent-doc item(s).
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three standalone snapshot scripts (
snapshot-super-editor-package-exports.mjs,snapshot-superdoc-legacy-exports.mjs,snapshot-superdoc-root-exports.mjs) shared no code but had identical CLI boilerplate and three separate CI step blocks. Consolidate into a single CLI with a family-module pattern.tests/consumer-typecheck/snapshot.mjsis the unified entry point. Dispatches on--allor--family <name>, with--check(default) or--write. Aggregates exit codes for--all.tests/consumer-typecheck/snapshot/exportsFAMILY,DESCRIPTION, andrun({ mode }): { code }. No shared abstraction; each family keeps its own enumeration and snapshot shape.ci-superdoc.yml,release-superdoc.yml,release-stable.ymlcollapse two step blocks into onesnapshot.mjs --all --checkcall.CONTRIBUTING.md,snapshots/README.md,deep-type-audit.README.md,packages/superdoc/AGENTS.mdupdated to reference the unified CLI.Review: drop-in CLI surface change. Same gates, same artifacts, same drift behavior; only the entry path moved.
Verified:
node tests/consumer-typecheck/snapshot.mjs --all --checkagainst the committed snapshots fromorigin/mainHEAD → all three families report no growth. Each family also passes individually via--family <name> --check.