revamp chrome extension#971
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | acdb1d8 | May 19 2026, 10:40 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | acdb1d8 | Commit Preview URL Branch Preview URL |
May 19 2026, 10:42 AM |
- Remove dead code after return statements in chatgpt.ts and claude.ts - Replace forEach callbacks that return values with for...of loops - Prefix unused function with underscore (appendStoredMemories) - Apply formatting fixes to all changed files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Claude finished @ishaanxgupta's task in 2m 58s —— View job Review Complete: revamp chrome extension
Summary: This PR adds Gemini support to the browser extension, introduces a new memory suggestion UI with Tab-to-accept functionality, and refactors platform-specific code to use shared components. The implementation is solid with proper error handling and no security vulnerabilities. Minor issues noted:
Score: 9/10 — Clean implementation, ready to ship after addressing the minor items above. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview: Adds Gemini support to the browser extension, introduces a new memory suggestion UI with Tab-to-accept functionality, refactors platform-specific code to use shared components, and improves error handling in the popup.
Issues found:
- Debug flags (
CHATGPT_DEBUG,CLAUDE_DEBUG,GEMINI_DEBUG) are all hardcoded totrue— will cause verbose console output in production - Dead code:
_appendStoredMemoriesfunction in gemini.ts is defined but never used
The implementation is well-structured with proper error handling, no XSS vulnerabilities (all dynamic content uses textContent instead of innerHTML), and good separation of concerns via the shared memory-suggestion.ts module.
Score: 9/10
Clean implementation with only minor housekeeping items to address before shipping.
| let geminiDebounceTimeout: NodeJS.Timeout | null = null | ||
| let geminiRouteObserver: MutationObserver | null = null | ||
| let geminiUrlCheckInterval: NodeJS.Timeout | null = null | ||
| let geminiObserverThrottle: NodeJS.Timeout | null = null |
There was a problem hiding this comment.
Debug flag is hardcoded to true. This applies to all three platform files (chatgpt.ts, claude.ts, gemini.ts). In production, this will result in verbose console output on every user interaction.
Consider either:
- Setting this to
falsebefore merging - Using an environment variable or build flag
| let geminiObserverThrottle: NodeJS.Timeout | null = null | |
| const GEMINI_DEBUG = false |
| return input.innerText || input.textContent || "" | ||
| } | ||
|
|
||
| function _appendStoredMemories(input: GeminiInput, storedMemories: string) { |
There was a problem hiding this comment.
This function is defined but never called anywhere in the codebase. Consider removing it if it's no longer needed, or if it's intended for future use, add a TODO comment explaining when it should be used.
1 participant
extension works across chatgpt, gemini, claude. there is a live marker now with tool tip that shows supermemory is connected, the welcome msg is revamped fully.
The autocomplete works as expected.
here is a photo of the welcome page:
