fix: hangling default int64 values for integer components of type int64#2287
Open
BorealFeast wants to merge 1 commit intoswagger-api:masterfrom
Open
fix: hangling default int64 values for integer components of type int64#2287BorealFeast wants to merge 1 commit intoswagger-api:masterfrom
BorealFeast wants to merge 1 commit intoswagger-api:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-parser!
Please fill out the following checklist to help us review your PR efficiently.
Description
Bug fix:
When deserializing a default value that is bigger than a int32, the value is returned as null.
This change allows to have default values up to int64 size when the type of the integer is specified as int64.
The change is mostly for the field default, but I took care to cover other fields that could accept int64 values (which were working fine) . See test for details.
Type of Change
Checklist
Screenshots / Additional Context