jextract/jni/ffm: Prevent Swift overloads by parameter names causing duplicate names in Java, add suffix to names#629
Merged
ktoso merged 2 commits intoswiftlang:mainfrom Mar 18, 2026
Conversation
Swift allows method overloading via parameter labels (e.g. takeValue(a:) and takeValue(b:)), but both produce the same Java signature. This adds a DuplicateNames analysis that detects actual conflicts and appends parameter label suffixes (e.g. takeValue_a, takeValue_b) only when needed. Non-overloaded methods keep their clean names. Co-authored-by: clemo97 <lumumbaclement@gmail.com>
ktoso
changed the title
ktoso
changed the title
Also handle the same in JNI and FFM
ktoso
force-pushed
the
wip-clemo97-overload-conflicts
branch
from
5f17361 to
49d2f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swift allows method overloading via parameter labels (e.g. takeValue(a:) and takeValue(b:)), but both produce the same Java signature. This adds a DuplicateNames analysis that detects actual conflicts and appends parameter label suffixes (e.g. takeValueA, takeValueB) only when needed. Non-overloaded methods keep their clean names.
From the original PR this moved on to do
camelCasesince it's more idiomatic for Java users, and I also made the same thing work in JNI and FFM modes.This takes over #544 to complete it as author was not responsive over the few months.
Disclaimer: AI assisted tests and aligning FFM and JNI modes to do the same handling.