[windows] fix sccache regex #86142
Open
[windows] fix sccache regex #86142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
I'm not sure why #86109 worked in my testings when I tried it at desk. The archive was .tar.gz and the script worked fine. |
Contributor
Author
|
@swift-ci please smoke test |
compnerd
reviewed
Jan 5, 2026
| if ($EnableCaching) { | ||
| $SCCache = Get-SCCache | ||
| $FileExtension = if ($SCCache.URL -match '/[^/]+(\..+)$') { $Matches[1] } else { | ||
| $FileExtension = if ($SCCache.URL -match '\.(?:tar\.gz|zip)$') { $Matches[0] } else { |
Member
There was a problem hiding this comment.
This seems overly constraining. Why not support tar.xz? tzx is also a common extension for gzip'ed tarballs. The original RegEx would've/should've permitted that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the regular expression used to determine the extension of the sccache archive.
This is a follow up to #86109.