Skip to content

pnp: Fix init and document values#568

Open
crawfxrd wants to merge 3 commits intomasterfrom
dev/pnp-names
Open

pnp: Fix init and document values#568
crawfxrd wants to merge 3 commits intomasterfrom
dev/pnp-names

Conversation

@crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Mar 13, 2026

IHIOA notes that:

The I/O address is an offset from the LSB bits of the address of the host controlled module.

So it should not be set to the actual addresses configured in BADRSEL, but the offset of them. So 0 for the address port (0x2E) and 1 for the data port (0x2F).

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd requested review from a team March 13, 2026 22:09
@crawfxrd crawfxrd force-pushed the dev/pnp-names branch 2 times, most recently from 341513e to bb720d0 Compare March 14, 2026 04:05
@crawfxrd crawfxrd changed the title pnp: Only modify required bits, add names for LDNs and host indexes pnp: Fix init and document values Mar 14, 2026
Signed-off-by: Tim Crawford <tcrawford@system76.com>
IHIOA notes that:

> The I/O address is an offset from the LSB bits of the address of the
> host controlled module.

So it should not be set to the actual addresses configured by BADRSEL, but
the _offset_ of them. So 0 for the address port (0x2E) and 1 for the
data port (0x2F).

Ref: IT5570E V0.3.2 datasheet; 7.15.4.1 Indirect Host I/O Address Register (IHIOA)
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
Copy link
Member Author

I don't know what the implications of the IHIOA change are.
Does it matter since we don't enable resources in coreboot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant