This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Closed
Conversation
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Author
|
/try |
|
Okay, starting a try! I'll update this comment once it's running... |
nickgerace
previously approved these changes
Nov 20, 2025
jkeiser
force-pushed
the
jkeiser/update-nix-pkgs
branch
from
1b91bed to
c8f10c3
Compare
Contributor
Author
|
Not sure why gjs is having issues. It doesn't repro locally. It was updated in nixpkgs 3 weeks ago, which should be ample time to have sussed out issues. ... and it's a little puzzling that we're depending on Gnome/GTK packages. |
nickgerace
reviewed
Nov 24, 2025
Comment on lines
+49
to
58
| # NOTE 2025-01-21: gjs-1.86.0 has a test failure (CommandLine test crashes) | ||
| # Skip GTK tests and disable doCheck to allow the build to complete | ||
| # See: https://github.com/NixOS/nixpkgs/pull/461666 | ||
| (final: prev: { | ||
| gjs = prev.gjs.overrideAttrs (old: { | ||
| mesonFlags = (old.mesonFlags or []) ++ ["-Dskip_gtk_tests=true"]; | ||
| doCheck = false; | ||
| }); | ||
| }) | ||
| ]; |
Contributor
There was a problem hiding this comment.
I went to the PR link and it was merged last week. Does that mean this override is still needed?
Contributor
Author
There was a problem hiding this comment.
It might mean we can just nix flake update and not need the workaround, yeah! Let's try it Monday.
Contributor
|
@jkeiser do we still want this? No rush, just curious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prisma wants a more recent node (we're at 20.9, it wants 20.19+), and we need to update this periodically anyway.
How was it tested?
In short: 🔗