Skip to content

Add more packager checks for OAuth config#1302

Open
pvanderknyff wants to merge 5 commits intomasterfrom
pv/defualt-check
Open

Add more packager checks for OAuth config#1302
pvanderknyff wants to merge 5 commits intomasterfrom
pv/defualt-check

Conversation

@pvanderknyff
Copy link
Copy Markdown
Contributor

@pvanderknyff pvanderknyff commented Apr 9, 2026

Added the following checks:

  • If there is a default config ID defined with a default config ID (ie not a missing id), check that it is lowercase.
  • If there are any config ids, check that there is a default config (either explicitly defined or inferred by no ID)
  • Check that there are no duplicate IDs. This check fails if we have both default and missing ID

Connectors with no embedded configs will not be affected.

The checks all fail because of an issue with the test framework we are using being deprecated. Have a followup story to address this but until then have confirmed all tests pass locally.

@pvanderknyff pvanderknyff requested a review from jinli-dev April 9, 2026 21:54
@pvanderknyff pvanderknyff changed the title Block non-lowercase default in oauth config element in packager Add more packager checks for OAuth config Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant