Skip to content

Memoizing instead of storing and updating state #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dolezel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Memoizing instead of storing and updating state #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 18 additions & 25 deletions src/SelectMultiple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,30 +55,23 @@ export default class SelectMultiple extends Component {
renderLabel: null
}

constructor (props) {
super(props)
this.state = { dataSource: [] }
}

componentDidMount () {
const rows = this.getRowData(this.props)
this.setState({ dataSource: rows })
}

componentWillReceiveProps (nextProps) {
const rows = this.getRowData(nextProps)
this.setState({ dataSource: rows })
}

getRowData ({ items, selectedItems }) {
items = items.map(this.toLabelValueObject)
selectedItems = (selectedItems || []).map(this.toLabelValueObject)

items.forEach((item) => {
item.selected = selectedItems.some((i) => i.value === item.value)
})
items = undefined
selectedItems = undefined
rowData = []

getRowData (items, selectedItems) {
if (items !== this.items || selectedItems !== this.selectedItems) {
this.items = items
this.selectedItems = selectedItems
this.rowData = items.map(this.toLabelValueObject)
selectedItems = (selectedItems || []).map(this.toLabelValueObject)

this.rowData.forEach((item) => {
item.selected = selectedItems.some((i) => i.value === item.value)
})
}

return items
return this.rowData
}

onRowPress (row) {
Expand Down Expand Up @@ -113,8 +106,8 @@ export default class SelectMultiple extends Component {
keyExtractor = (item, index) => index.toString()

render () {
const { dataSource } = this.state
const { style, flatListProps, keyExtractor } = this.props
const { style, flatListProps, keyExtractor, items, selectedItems } = this.props
const dataSource = this.getRowData(items, selectedItems)
return (
<FlatList
style={style}
Expand Down