Open
Conversation
Bump tailscale so that we can simplify tests now that self-dial works. Fix a bug in TsnetGetRemoteAddr where the listener's addr map was keyed by the sender-side fd (closed after sendmsg), but looked up by the receiver-side fd (a different number from recvmsg). This worked by coincidence when fd allocation was predictable but broke under self-dial. Fix by sending the remote address string as sendmsg data alongside the fd rights, and populating the map in TsnetAccept with the received fd. Add make test target that runs all test suites available on the host platform (Go always, Ruby if bundler is present, Swift if on macOS with xcodebuild).
bradfitz
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump tailscale so that we can simplify tests now that self-dial works.
Fix a bug in TsnetGetRemoteAddr where the listener's addr map was keyed by the sender-side fd (closed after sendmsg), but looked up by the receiver-side fd (a different number from recvmsg). This worked by coincidence when fd allocation was predictable but broke under self-dial. Fix by sending the remote address string as sendmsg data alongside the fd rights, and populating the map in TsnetAccept with the received fd.
Add make test target that runs all test suites available on the host platform (Go always, Ruby if bundler is present, Swift if on macOS with xcodebuild).