Skip to content

fix(audit): redact quoted secret values#20

Merged
jamiesun merged 1 commit into
mainfrom
codex/audit-redaction-quoted-secrets
Jun 20, 2026
Merged

fix(audit): redact quoted secret values#20
jamiesun merged 1 commit into
mainfrom
codex/audit-redaction-quoted-secrets

Conversation

@jamiesun

Copy link
Copy Markdown
Contributor

Fixes #19.

Summary

  • redact quoted sensitive assignment values before unquoted fallback
  • redact quoted sensitive flag values before unquoted fallback
  • add table-driven coverage for quoted and unquoted assignment/flag forms

Verification

  • go test ./internal/app -run 'TestRedactSensitiveTextCoversQuotedAndUnquotedValues|TestRun_BlockedCommandWritesRedactedAuditEvent'
  • go test ./...
  • git diff --check
  • make check
  • manual smoke: blocked command with password="alpha bravo" and --token "charlie delta" writes only values to audit JSONL

@jamiesun jamiesun merged commit 8be2f13 into main Jun 20, 2026
6 checks passed
@jamiesun jamiesun deleted the codex/audit-redaction-quoted-secrets branch June 20, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[audit] Quoted secret values with spaces are only partially redacted

1 participant