Ref/model by atakanargn · Pull Request #2 · tapsilat/tapsilat-java

atakanargn · 2026-04-10T05:23:35Z

order and subsciption dto parity fix and tests updated

Copilot

Pull request overview

This PR updates the Java SDK models/services to better match (“parity”) the Order/Subscription API payloads and expands test coverage around DTO serialization and service calls.

Changes:

Rename/align order request types (OrderRequest → OrderCreateRequest) and update validator/service/builder usage accordingly.
Adjust subscription and organization DTOs/service methods for updated request/response shapes.
Add extensive unit tests plus a manual Apache HttpClient test double to avoid Mockito instrumentation issues.

Reviewed changes

Copilot reviewed 41 out of 42 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/test/java/org/apache/hc/client5/http/impl/classic/CloseableHttpResponseAdapter.java	Test-only adapter to access package-private `CloseableHttpResponse.adapt`.
src/test/java/com/tapsilat/unit/validation/ValidatorTest.java	Adds tests for GSM cleaning, installment validation, and validator behavior.
src/test/java/com/tapsilat/unit/utils/MockHttpClient.java	Manual `CloseableHttpClient` stub capturing requests and returning stub responses.
src/test/java/com/tapsilat/unit/service/SubscriptionServiceTest.java	Adds service tests for subscription create/get/list/cancel/redirect.
src/test/java/com/tapsilat/unit/service/OrganizationServiceTest.java	Adds service tests for organization endpoints.
src/test/java/com/tapsilat/unit/service/OrderServiceTest.java	Adds broad service tests for order endpoints.
src/test/java/com/tapsilat/unit/model/SubscriptionModelTest.java	Adds JSON serialization tests for subscription DTOs.
src/test/java/com/tapsilat/unit/model/OrganizationModelTest.java	Adds JSON serialization tests for organization DTOs.
src/test/java/com/tapsilat/unit/model/OrderModelTest.java	Adds JSON serialization tests for order DTOs.
src/test/java/com/tapsilat/unit/model/OrderDTOSerializationTest.java	Adds comprehensive DTO serialization/deserialization coverage for orders.
src/test/java/com/tapsilat/unit/model/CommonModelTest.java	Fixes package and updates Buyer construction usage.
src/test/java/com/tapsilat/unit/TapsilatClientTest.java	Updates tests to use `OrderCreateRequest` / GSM setter changes.
src/test/java/com/tapsilat/integration/TapsilatClientLiveExample.java	Updates example package and order request type usage.
src/test/java/com/tapsilat/integration/TapsilatClientExample.java	Updates example package and order request type usage.
src/test/java/com/tapsilat/integration/TapsilatClientComprehensiveExample.java	Updates example package and aligns fields (e.g., paymentMethods).
src/test/java/com/tapsilat/integration/IntegrationTest.java	Adds real API integration tests guarded by env/.env token.
src/test/java/com/tapsilat/IntegrationTest.java	Removes old integration test.
src/test/java/com/tapsilat/EnumTest.java	Removes old enum test.
src/test/java/com/tapsilat/CheckType.java	Adds a local debugging helper for HttpClient type inspection.
src/main/java/com/tapsilat/validation/OrderRequestValidator.java	Updates validator to accept `OrderCreateRequest`, revises GSM cleaning + installment validation.
src/main/java/com/tapsilat/service/SubscriptionService.java	Changes `list` to return a raw map payload.
src/main/java/com/tapsilat/service/OrganizationService.java	Updates request types for create/verify operations.
src/main/java/com/tapsilat/service/OrderService.java	Updates `create` to accept `OrderCreateRequest`.
src/main/java/com/tapsilat/model/subscription/SubscriptionPriceOption.java	Removes `SubscriptionPriceOption` model.
src/main/java/com/tapsilat/model/subscription/SubscriptionCreateRequest.java	Removes `price_option` from create request.
src/main/java/com/tapsilat/model/organization/SetLimitUserRequest.java	Changes payload from `limit` to `limit_id`.
src/main/java/com/tapsilat/model/organization/OrgUserVerifyRequest.java	Adds new verify request model (user_id based).
src/main/java/com/tapsilat/model/organization/OrgUserVerifyReq.java	Removes old verify request model.
src/main/java/com/tapsilat/model/organization/OrgUserMobileVerifyRequest.java	Adds new mobile-verify request model (user_id based).
src/main/java/com/tapsilat/model/organization/OrgUserMobileVerifyReq.java	Removes old mobile-verify request model.
src/main/java/com/tapsilat/model/organization/OrgCreateUserRequest.java	Renames request type and aligns class name with file name.
src/main/java/com/tapsilat/model/organization/GetVposRequest.java	Switches from `currency` to `currency_id`.
src/main/java/com/tapsilat/model/order/OrderCreateRequest.java	Renames and aligns fields (e.g., order_cards as list) and removes description/callbackUrl.
src/main/java/com/tapsilat/model/common/ShippingAddress.java	Adds tracking/shipping fields and includes them in equals/hashCode.
src/main/java/com/tapsilat/model/common/OrderPFSubMerchant.java	Adds `national_id` and `switch_id`.
src/main/java/com/tapsilat/model/common/Buyer.java	Removes `phone` field and updates constructors/equals/hashCode accordingly.
src/main/java/com/tapsilat/model/common/BillingAddress.java	Adds multiple billing fields and includes them in equals/hashCode.
src/main/java/com/tapsilat/model/common/BasketItem.java	Adds `mcc` and expands equality/hash/printing and accessors.
src/main/java/com/tapsilat/builder/OrderRequestBuilder.java	Updates builder to build `OrderCreateRequest` and align buyer/order_cards handling.
src/main/java/com/tapsilat/TapsilatClient.java	Updates backward-compatible `createOrder` to accept `OrderCreateRequest`.
pom.xml	Updates Mockito deps and adds surefire JVM args.
.gitignore	Adds ignores for a Maven directory and `src/main/docker`.

Comments suppressed due to low confidence (1)

src/main/java/com/tapsilat/model/order/OrderCreateRequest.java:18

The class-level Javadoc still lists description/callbackUrl as optional fields, but those properties have been removed from OrderCreateRequest. Please update the documentation so it matches the actual serialized fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-20T19:36:54Z

+        <configuration>
+          <argLine>
+            -XX:+EnableDynamicAgentLoading
+            --add-opens java.base/java.lang=ALL-UNNAMED
+            --add-opens java.base/java.util=ALL-UNNAMED
+            --add-opens java.base/java.io=ALL-UNNAMED
+            --add-opens java.base/java.net=ALL-UNNAMED
+          </argLine>


The surefire is set directly, which will override any future tool/plugin that relies on ${argLine} (e.g., JaCoCo). Prefer prefixing with ${argLine} so additional JVM args can compose cleanly.

Copilot · 2026-04-20T19:36:54Z

+    @Test
+    public void testScenario1_BasicOrder() throws Exception {
+        if (token == null) {
+            skipTest("testScenario1_BasicOrder");
+            return;
+        }
+
+        OrderCreateRequest order = new OrderCreateRequest();
+        order.setAmount(BigDecimal.valueOf(100.00));
+        order.setCurrency("TRY");
+        order.setLocale("tr");
+        order.setBuyer(new Buyer("John", "Doe", "test@example.com"));
+
+        OrderResponse response = client.orders().create(order);
+        assertNotNull(response);
+        assertNotNull(response.getReferenceId());
+    }


These tests execute real API calls when TAPSILAT_API_KEY is present, and they live under src/test/java so they will run in the default unit-test phase. Consider marking the class/methods as @tag("integration") and excluding that tag from the default surefire run (or using @Disabled / a Maven profile) to avoid accidental live calls in CI/dev environments.

Copilot · 2026-04-20T19:36:55Z

+    public OrderRequestBuilder orderCards(List<OrderCard> orderCards) {
+        this.orderCards = new ArrayList<>(orderCards);
+        return this;
+    }
+
+    public OrderRequestBuilder addOrderCard(OrderCard orderCard) {
+        this.orderCards.add(orderCard);
        return this;


orderCards(List) copies the input with new ArrayList<>(orderCards) without a null check, which will throw NPE if a caller passes null (unlike other builder setters that accept null in some cases). Consider treating null as an empty list, or document/enforce non-null explicitly (e.g., Objects.requireNonNull).

Copilot · 2026-04-20T19:36:55Z

    @JsonProperty("title")
    private String title;

    @JsonProperty("user")
    private SubscriptionUser user;



Removing the price_option field from SubscriptionCreateRequest is a breaking change for SDK consumers. If the API no longer supports it that’s fine, but consider keeping the field (and SubscriptionPriceOption type) deprecated for at least one release cycle, or providing a clear migration path in code/docs.

Copilot · 2026-04-20T19:36:56Z

+    @SuppressWarnings("unchecked")
+    public Map<String, Object> list(Integer page, Integer perPage) throws TapsilatException {
        try {
            Map<String, String> params = new HashMap<>();
            if (page != null)
                params.put("page", String.valueOf(page));
            if (perPage != null)
                params.put("per_page", String.valueOf(perPage));

-            SubscriptionListItem[] items = executeRequest(
+            return executeRequest(
                    buildRequest("GET", TapsilatConstants.ENDPOINT_SUBSCRIPTION_LIST, null, params),
-                    SubscriptionListItem[].class);
-            return items != null ? java.util.Arrays.asList(items) : java.util.Collections.emptyList();
+                    Map.class);


Changing list(...) from returning List to returning a raw Map is a breaking public API change (and loses type safety). If the endpoint response shape has changed, consider adding a new method (e.g., listRaw / listResponse) while keeping the typed list method for backwards compatibility, or introduce a typed response DTO that matches the API payload.

Copilot · 2026-04-20T19:36:56Z

    /**
     * Constructor with all fields.
     * 
     * @param name           Buyer's first name (required)
     * @param surname        Buyer's last name (required)
     * @param email          Buyer's email address (required)
     * @param phone          Buyer's phone number (optional)
     * @param identityNumber Buyer's identity number (optional)
     * @throws NullPointerException if any required parameter is null
     */
-    public Buyer(String name, String surname, String email, String phone, String identityNumber) {
+    public Buyer(String name, String surname, String email, String identityNumber) {
        this.name = Objects.requireNonNull(name, "Buyer name cannot be null");
        this.surname = Objects.requireNonNull(surname, "Buyer surname cannot be null");
        this.email = Objects.requireNonNull(email, "Buyer email cannot be null");
-        this.phone = phone;
        this.identityNumber = identityNumber;
    }


The constructor Javadoc still documents a "phone" parameter, but the constructor signature no longer takes it. Please update the Javadoc (and the "Constructor with all fields" wording) to reflect the new parameters and how callers should set gsmNumber if needed.

salihdev0

lgtm but copilot reviews are important

TarikSogukpinar · 2026-04-20T22:14:51Z

lgtm but one inconsistency buyer is optional in Swagger but still required by SDK validation.

hmert · 2026-04-21T09:21:48Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/tapsilat/tapsilat-java/sessions/932150a5-cc9c-4614-a7b2-875f81ee5054 Co-authored-by: hmert <182906+hmert@users.noreply.github.com>

Copilot · 2026-04-21T09:38:55Z

lgtm but one inconsistency buyer is optional in Swagger but still required by SDK validation.

Updated in 77a9bdc: buyer is now optional in SDK order validation to align with Swagger, and tests were adjusted accordingly.

@copilot apply changes based on the comments in this thread

Applied the review-thread fixes in 77a9bdc (with follow-up refinement in 3a7c1e6), including integration test tagging/exclusion, null-safe builder handling, subscription API compatibility updates, GSM normalization update, buyer-validation alignment, Javadoc cleanup, and test cleanup.

atakanargn added 5 commits April 9, 2026 23:02

refactor(model): update order and subscription models

9f407c3

feat(model): add missing fields to billing, shipping, and basket models

3fcca6a

refactor(validation): normalize gsm validation to be universal

cb14201

test: align examples and test suites with simplified model architecture

bd64c26

refactor(subscription): delete obsolete SubscriptionPriceOption model

14685f3

hmert requested review from TarikSogukpinar and salihdev0 April 10, 2026 13:46

atakanargn added 3 commits April 20, 2026 21:20

refactor(test): restructure tests into unit and integration

a64772c

feat(model): add standardized request models for order and organization

3751aed

chore: cleanup and final adjustments

d980801

hmert requested a review from Copilot April 20, 2026 19:28

Copilot started reviewing on behalf of hmert April 20, 2026 19:28 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

salihdev0 approved these changes Apr 20, 2026

View reviewed changes

TarikSogukpinar approved these changes Apr 20, 2026

View reviewed changes

Copilot started work on behalf of hmert April 21, 2026 09:21 View session

Copilot AI and others added 5 commits April 21, 2026 09:32

fix: address review feedback and restore SDK compatibility

77a9bdc

Agent-Logs-Url: https://github.com/tapsilat/tapsilat-java/sessions/932150a5-cc9c-4614-a7b2-875f81ee5054 Co-authored-by: hmert <182906+hmert@users.noreply.github.com>

refactor: simplify gsm normalization pass in order validator

3a7c1e6

Agent-Logs-Url: https://github.com/tapsilat/tapsilat-java/sessions/932150a5-cc9c-4614-a7b2-875f81ee5054 Co-authored-by: hmert <182906+hmert@users.noreply.github.com>

chore: remove accidental maven wrapper artifact changes

36b3c0e

Agent-Logs-Url: https://github.com/tapsilat/tapsilat-java/sessions/932150a5-cc9c-4614-a7b2-875f81ee5054 Co-authored-by: hmert <182906+hmert@users.noreply.github.com>

test: clarify gsm normalization test naming

d19f181

Agent-Logs-Url: https://github.com/tapsilat/tapsilat-java/sessions/932150a5-cc9c-4614-a7b2-875f81ee5054 Co-authored-by: hmert <182906+hmert@users.noreply.github.com>

chore: remove accidental maven wrapper files from commit

49b44e3

Agent-Logs-Url: https://github.com/tapsilat/tapsilat-java/sessions/932150a5-cc9c-4614-a7b2-875f81ee5054 Co-authored-by: hmert <182906+hmert@users.noreply.github.com>

Copilot finished work on behalf of hmert April 21, 2026 09:42

Copilot AI requested a review from hmert April 21, 2026 09:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ref/model#2

Ref/model#2
atakanargn wants to merge 13 commits into
mainfrom
ref/model

atakanargn commented Apr 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 20, 2026

Uh oh!

Copilot AI Apr 20, 2026

Uh oh!

Copilot AI Apr 20, 2026

Uh oh!

Copilot AI Apr 20, 2026

Uh oh!

Uh oh!

Copilot AI Apr 20, 2026

Uh oh!

Uh oh!

Copilot AI Apr 20, 2026

Uh oh!

salihdev0 left a comment

Uh oh!

TarikSogukpinar commented Apr 20, 2026

Uh oh!

hmert commented Apr 21, 2026

Uh oh!

Copilot AI commented Apr 21, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

atakanargn commented Apr 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

salihdev0 left a comment

Choose a reason for hiding this comment

Uh oh!

TarikSogukpinar commented Apr 20, 2026

Uh oh!

hmert commented Apr 21, 2026

Uh oh!

Copilot AI commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Apr 21, 2026 •

edited

Loading