request: switch all request types to value receivers and value returns#553
Open
request: switch all request types to value receivers and value returns#553
Conversation
bigbes
force-pushed
the
bigbes/gh-no-request-value-receivers
branch
from
1b92035 to
1e3c768
Compare
All New*Request()/Make*Request() constructors now return values instead of pointers. All methods on request types use value receivers and return values, enabling immutable builder-style chaining. Removed intermediate spaceRequest, spaceIndexRequest types from the tarantool package and spaceRequest from the crud package — space and index fields are inlined directly into each request struct. Converted all constructors to composite literal style. Applied the same pattern to arrow/ and settings/ packages. In the box/ subpackage, request types no longer embed tarantool.CallRequest. They store it as a private field via baseCallRequest and implement their own Context() method returning the wrapper type.
bigbes
force-pushed
the
bigbes/gh-no-request-value-receivers
branch
from
1e3c768 to
0581fc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
New*Request()/Make*Request()constructors now return values instead of pointers. All methods on request types use value receivers and return values, enabling immutable builder-style chaining.Removed intermediate
spaceRequest,spaceIndexRequesttypes from the tarantool package andspaceRequestfrom the crud package — space and index fields are inlined directly into each request struct.Converted all constructors to composite literal style.
Applied the same pattern to
arrow/andsettings/packages.In the
box/subpackage, request types no longer embedtarantool.CallRequest. They store it as a private field viabaseCallRequestand implement their ownContext()method returning the wrapper type.