-
Notifications
You must be signed in to change notification settings - Fork 49
ci: add integration tests that run with lowest and highest dependency… #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0704c1f to
1df45be
Compare
1df45be to
7d30d3a
Compare
taskcluster/kinds/test/windows.yml
Outdated
| worker: | ||
| taskcluster-proxy: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this enables the proxy, I wouldn't have expected it to be needed (I know you're just moving this code here, I just hadn't noticed this before).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I didn't notice either. @bhearsum was this intentional?
I'll leave it in this PR, we can attempt disabling in a follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have recollection of needing it. It could be copy/paste failure, or something I failed to document. I've opened #900 to remove it, and we'll see if that passes tests.
| "cookiecutter~=2.1", | ||
| "json-e>=2.7", | ||
| "mozilla-repo-urls", | ||
| "mozilla-repo-urls>=0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the last version that supports Python 3.9 and 3.10..
This might bite us eventually if we ever need to depend on a new change there.
| "sphinx-book-theme >=1.1.4", | ||
| "sphinx-taskgraph>=0.1.0", | ||
| "sphinxcontrib-mermaid>=1.0.0", | ||
| "zstandard>=0.25.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just put a minimum bound to the maximum version that still support 3.9 for these. They're just dev dependencies, so no need to keep a wide constraint.
7d30d3a to
7b41416
Compare
… resolution