Skip to content

feat: convert all schemas from voluptuous to msgspec#902

Merged
abhishekmadan30 merged 2 commits intotaskcluster:mainfrom
abhishekmadan30:new-schema-conv
Feb 11, 2026
Merged

feat: convert all schemas from voluptuous to msgspec#902
abhishekmadan30 merged 2 commits intotaskcluster:mainfrom
abhishekmadan30:new-schema-conv

Conversation

@abhishekmadan30
Copy link
Contributor

No description provided.

@abhishekmadan30 abhishekmadan30 requested a review from a team as a code owner February 10, 2026 05:11
@abhishekmadan30 abhishekmadan30 force-pushed the new-schema-conv branch 4 times, most recently from 3adb210 to 1991917 Compare February 10, 2026 14:57
Copy link
Collaborator

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I see you generally did do what I suggested below, looks like run/__init__.py was the main culprit. I didn't go over everything with a fine toothed comb yet but figured you can work on the comments in the meantime.

@abhishekmadan30
Copy link
Contributor Author

Yep, I had in the prompt, I just ended up redoing run/_init_.py so it forgot the original comment

@abhishekmadan30 abhishekmadan30 requested a review from ahal February 11, 2026 16:30
@abhishekmadan30
Copy link
Contributor Author

Also for context, I have structured the patch in this format to manage any fallout that comes from this conversion. The schema conversion in the first patch operate completely independently so if any issues arise with them, we can just revert that file specifically. The second patch have dependencies whether it be other schemas or test files therefore I thought it would be best to back out/revert the entire commit if any issues arise with those schema conversion

Copy link
Collaborator

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@abhishekmadan30 abhishekmadan30 merged commit a1a77e1 into taskcluster:main Feb 11, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants