Don't let note fetching stderr appear in logs unless fatal#936
Merged
Eijebong merged 1 commit intotaskcluster:mainfrom Apr 16, 2026
Merged
Conversation
Without this, we let the fetch command write to the logs with a `fatal: failed to fetch` despite it, in fact, not being fatal. This silences it by capturing stderr instead. I also realized that because of copy/pasting I wasn't using `self.run` for ls-remote which is inconsistent and might fail in mysterious ways in gecko since it wasn't using `self.env`
Eijebong
force-pushed
the
fix-notes-fetching-too-verbose
branch
from
da35c4c to
3c76eb5
Compare
jcristau
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, we let the fetch command write to the logs with a
fatal: failed to fetchdespite it, in fact, not being fatal. This silences it by capturing stderr instead. I also realized that because of copy/pasting I wasn't usingself.runfor ls-remote which is inconsistent and might fail in mysterious ways in gecko since it wasn't usingself.env