[sync] fix: t5149 route canary base duplicate through stream#3340
[sync] fix: t5149 route canary base duplicate through stream#3340tea-artist wants to merge 1 commit into
Conversation
Synced from teableio/teable-ee@b377419 Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b4a542df6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const commandResult = ImportCsvCommand.createFromUrl({ | ||
| baseId, | ||
| csvUrl: resolvedUrl, | ||
| tableName: worksheet.name, | ||
| importData: worksheet.importData, |
There was a problem hiding this comment.
When the importCsv canary is enabled, CSV create-table imports are routed through this V2 command, but only the URL/table name/importData flag are passed. The existing OpenAPI payload also carries worksheet.columns and useFirstRowAsHeader (V1 uses them to create the user-selected field names/types and decide whether to skip the first row). For CSVs where the user edited inferred columns or unchecked “first row as header”, V2 will re-infer the schema and treat the first data row as headers, producing the wrong table and records. Either pass those worksheet options into ImportCsvCommand or fall back to V1 for these cases.
Useful? React with 👍 / 👎.
2 participants
🔄 Automated sync from EE repository.
106 commit(s) synced since last sync.
Authors
Included commits
Latest source commit: teableio/teable-ee@b377419
This PR was automatically created by the sync workflow.