[feat/babashka] Add Babashka support with cross-platform core.cljc#7
Merged
[feat/babashka] Add Babashka support with cross-platform core.cljc#7
Conversation
…o ci] Unify `core.clj` and `core.cljs` into a single `core.cljc` with reader conditionals for platform differences. Extract file discovery into per-platform implementations (`files.clj`, `files.bb`, `files.cljs`) behind a shared `config-file-maps` interface. ## Changes - *src/tech/config/core.cljc* — new unified implementation replacing `core.clj` and `core.cljs`; `coercing-merge` is now fully cross-platform with `numeric?`, `parse-number`, `parse-bool` helpers - *src/tech/config/files.clj* — JVM file discovery via `clojure.java.classpath` with classpath dir + jar scanning - *src/tech/config/files.bb* — Babashka file discovery via `System/getProperty "java.class.path"` (classpath dirs only) - *src/tech/config/files.cljs* — Node.js file discovery via `fs` module (reads from `CONFIG_DIR` or `resources/`) - *src/tech/config/core.clj* — deleted (replaced by `core.cljc`) - *src/tech/config/core.cljs* — deleted (replaced by `core.cljc`) - *test/tech/config/config_test.clj* — update exception types from `IllegalArgumentException` to `Exception`; replace `read-string?` test with `default-value` test - *scripts/install* — add cross-platform Babashka install section; fix AWS CLI Linux install to use detected arch instead of hardcoded `x86_64`
Contributor
|
He's going in 🥂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core.cljandcore.cljsintocore.cljcwith reader conditionals for JVM/BB/CLJS differencesfiles.clj,files.bb,files.cljs) behind a sharedconfig-file-mapsinterfacecoercing-mergeis now fully cross-platform with small parsing helpers (numeric?,parse-number,parse-bool)scripts/install; fix AWS CLI arch detection on LinuxTest plan
get-config, env var override, type coercion,get-config-table-strall verifiedshadow-cljs compile test)