[Regression] Bring back original video quality option, handle attributes correctly

[comdev1337]

Fixes #29780
Fixes #30407
Fixes: a bug (?) where the video quality text (SD/HD/4K) is not displayed on the gear button if a video has no alt_documents (only speed options are available in the dropdown).

Summary

This PR aims to help the minor subset of users with a functioning eyesight by restoring the original video quality option in the media player. The original stream is included as the second option (consistent with the ordering in the Android client).

Example video. Observe: wheels turn into slop when 1080p is selected.

tg_original_quality_h264.mp4

Example video. Handling wrong attributes correctly. We now have a 1080p stream!

tg_original_wh_fix.mp4

Implementation

• Upon resolving video qualities, the original quality is added to the array with a 1000000 integer offset (Media::kVideoQualityOriginalOffset). This eliminates resolution ambiguity between an original 1080p stream and a sloppy 1080p.
• The settings deserializer has been updated to accept values up to 1004320 to ensure the "Original" quality preference persists across restarts.
• Tie-Breaker Fix: Fixed an edge case in chooseQuality() where selecting the transcoded 1080p option selects the original 1080p, if the transcoded stream size is over the original file size, due to

if (abs == closestAbs && quality->size < closestSize)

• Get video dimensions from ffmpeg directly (realsize), do not rely on attributes whenever possible.

---

Tried throwing a bunch of different videos at it. Works on my machine.

[23rd]

_chosenQuality != _document)

Does it really make sense?

[comdev1337]

This is necessary. We do not want to rely on the provided duration attribute, which might be fake.

See: https://t.me/cursedvideofiles/7

If you open the 720p or 480p stream in 6.6.2, you'll end up with

1. fake duration
2. video player dimensions change according to fake w, h attributes

I aim to resolve these 2 issues:

[comdev1337]

Made the player more resistant against incorrect width, height, duration attributes. Unfortunately, fake w, h are common.

• The player should now correctly adjust the size per the stream selected.
• The player accounts for weird edge cases (like non-square SAR) when extracting the height for the original doc.

Put some edge cases the current player doesn't account for in https://t.me/cursedvideofiles

Should fix #30407

[23rd]

Physical? 😨

[comdev1337]

Physical as in the stream resolution as reported by ffmpeg, as opposed to size which is adjusted for SAR.
I can rename it to smth like "encoded resolution" if that makes more sense?

[FishOrBear]

I tested this PR, and the results are excellent. Previously, the system would generate an AV1-encoded video, which caused the video playback to freeze; now, it utilizes the original video (H.264), thereby preventing the freezing issue.

[john-preston]

I'll rewrite it, but thanks.

[john-preston]

ah. now conflicts , sorry @comdev1337, fix please

[comdev1337]

@john-preston fixed

[comdev1337]

@FishOrBear

Previously, the system would generate an AV1-encoded video, which caused the video playback to freeze; now, it utilizes the original video (H.264)

This may still be an issue if you select a transcoded stream. I believe the client prioritizes fetching av01 over h264 for these.

[FishOrBear]

@FishOrBear

Previously, the system would generate an AV1-encoded video, which caused the video playback to freeze; now, it utilizes the original video (H.264)

This may still be an issue if you select a transcoded stream. I believe the client prioritizes fetching av01 over h264 for these.

Yes, now I just need to select the original video.

It would be helpful to improve the video quality selection button by displaying the video's encoding format and file size; this would make debugging much easier. This is how it works on Telegram for Android.

[comdev1337]

It would be helpful to improve the video quality selection button by displaying the video's encoding format and file size; this would make debugging much easier. This is how it works on Telegram for Android.

The Android client doesn't display the codec, from what I can see