RMB gear to toggle video speedup#30418
Open
comdev1337 wants to merge 1 commit intotelegramdesktop:devfrom
Open
RMB gear to toggle video speedup#30418comdev1337 wants to merge 1 commit intotelegramdesktop:devfrom
comdev1337 wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
Contributor
|
alternative actions are usually mapped to ctrl+click in the app... |
Contributor
Author
|
I am no UX designer but
|
Contributor
|
@comdev1337 I recently wanted to add mention-by-name with RMB since it's unused but Preston said I have to use Ctrl+Click anyway |
Contributor
Author
|
@ilya-fedin It took me some time to figure out what you actually meant by "mention-by-name with Ctrl+Click". I initially assumed you mean Ctrl+Clicking a user in the chat members list would add a mention in the "Write a message..." text field. This would have been more useful imo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking (LMB) the "gear" button used to toggle between normal speed (1x) and the last used custom speed (
kSpedUpDefaultby default). Apparently this was removed when the quality gear button was introduced. LMB now just opens/closes the dropdown quality/speed menu.tg_speed_old_h264.mp4
Changing the speed via the slider (when the menu is filled with quality options) is a pain the ass.
We can restrore this functionality by using RMB to toggle between normal speed (1.0x) and the last used custom speed.
tg_rmb_toggle_speedup.mp4