Fix startapp/startattach deeplinks for bots with Threaded Mode.#30543
Open
rdmcd wants to merge 1 commit intotelegramdesktop:devfrom
Open
Fix startapp/startattach deeplinks for bots with Threaded Mode.#30543rdmcd wants to merge 1 commit intotelegramdesktop:devfrom
rdmcd wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
Extract attach bot handlers (attachBotUsername, attachBotMainOpen, attachBotToggleCommand) from the final else block into standalone branches above the isForum() check, so forum view doesn't intercept bot deeplinks. Follows the same reorder approach as telegramdesktop#30446. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes Telegram Desktop deeplink handling for bot mini-app links (?startapp default mini app, ?startattach, and ?attach) when the target bot has Threaded Mode enabled, by ensuring those deeplink handlers run before the peer->isForum() branch that previously intercepted the flow.
Changes:
- Extract
attachBotUsername,attachBotMainOpen, andattachBotToggleCommandhandling out of the finalelseblock. - Reorder deeplink handling so attach/startapp/startattach branches execute before
peer->isForum()without changing theisForum()condition itself.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30446 — in that PR I fixed only named bot app links (t.me/bot/appname) by moving isForum() below the BotApp resolve type handler, but missed that ?startapp
(default mini app), ?startattach and ?attach deeplinks were handled inside the final else block and still intercepted by isForum().