Skip to content

fix(http): fix database session installer with migrations #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendt merged 3 commits into from
Mar 10, 2026
Merged

fix(http): fix database session installer with migrations #2034

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c744c62
wip
brendt Mar 10, 2026
6c74ed0
wip
brendt Mar 10, 2026
60d5f16
wip
brendt Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions packages/http/src/Session/Installer/DatabaseSessionInstaller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,11 @@

use Tempest\Console\Console;
use Tempest\Console\Input\ConsoleArgumentBag;
use Tempest\Container\Container;
use Tempest\Core\Installer;
use Tempest\Core\PublishesFiles;
use Tempest\Database\Migrations\MigrationManager;

use function Tempest\root_path;
use function Tempest\src_path;
use function Tempest\Support\Namespace\to_fqcn;

final class DatabaseSessionInstaller implements Installer
{
Expand All @@ -23,7 +20,6 @@ final class DatabaseSessionInstaller implements Installer

public function __construct(
private readonly MigrationManager $migrationManager,
private readonly Container $container,
private readonly Console $console,
private readonly ConsoleArgumentBag $consoleArgumentBag,
) {}
Expand All @@ -43,9 +39,7 @@ public function install(): void
$this->publishImports();

if ($migration && $this->shouldMigrate()) {
$this->migrationManager->executeUp(
migration: $this->container->get(to_fqcn($migration, root: root_path())),
);
$this->migrationManager->up();
}
}

Expand All @@ -54,7 +48,7 @@ private function shouldMigrate(): bool
$argument = $this->consoleArgumentBag->get('migrate');

if ($argument === null || ! is_bool($argument->value)) {
return $this->console->confirm('Do you want to execute migrations?', default: false);
return $this->console->confirm('Do you want to execute migrations?');
}

return (bool) $argument->value;
Expand Down
Loading