-
Notifications
You must be signed in to change notification settings - Fork 92
time skipping fast forward #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2387,6 +2387,10 @@ message UpdateWorkflowExecutionOptionsRequest { | |
| message UpdateWorkflowExecutionOptionsResponse { | ||
| // Workflow Execution options after update. | ||
| temporal.api.workflow.v1.WorkflowExecutionOptions workflow_execution_options = 1; | ||
|
|
||
| // The Workflow Execution time when the options were updated. When time skipping is | ||
| // enabled, this is the workflow's virtual time rather than wall-clock time. | ||
| google.protobuf.Timestamp update_time = 2; | ||
|
Comment on lines
+2390
to
+2393
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How does this get used? Does SDK need to use this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think so but it is just a refinement/enhancement that when SDK checks the time skipping event it can re-verifies the time is correct. this is only needed in edgy case: |
||
| } | ||
|
|
||
| // [cleanup-wv-pre-release] Pre-release deployment APIs, clean up later | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to add "a call" in this comment as there won't be any extra calls from the client side to disable it ?