Skip to content

temporal worker deployment create|create-version#971

Open
jaypipes wants to merge 9 commits intotemporalio:serverlessfrom
jaypipes:jaypipes/serverless
Open

temporal worker deployment create|create-version#971
jaypipes wants to merge 9 commits intotemporalio:serverlessfrom
jaypipes:jaypipes/serverless

Conversation

@jaypipes
Copy link
Copy Markdown

@jaypipes jaypipes commented Mar 31, 2026

Adds implementation of the temporal worker deployment create and
temporal worker deployment create-version CLI commands using only
direct gRPC API calls, not the sdk-go client code.

Adds some basic unit tests for both commands though due to the
server-side validation of proper AWS IAM credentials, the happy-path
temporal worker deployment create-version call with AWS Lambda compute
config is skipped until such time as we can figure out adding real AWS
test fixtures.

chaptersix and others added 5 commits March 12, 2026 15:54
Fixes temporalio#567

## What was changed
- When executing short-lived transactional commands (e.g. `start`,
`list` etc, as opposed to the long-running `server start-dev` process)
report errors/warnings as unstructured plain text instead of structured
logging-formatted messages.
- The logger is now used only by the server and SDK

## Why?
CLIs should report errors/warnings by printing to stderr. They should
not use structured logging messages for this.

## How was this tested
- New in-codebase tests
- Manually.
## Summary
- Replace `@temporalio/sdk @temporalio/server` with `@temporalio/act` as
code owners
…#966)

## What was changed
Add experimental warning around pause/update-options/unpause/reset
activity by type or use of --query flag with activity operations.

## Why?
These have been experimental commands and should have been marked
experimental from the beginning.

## Checklist
1. Closes NA

2. How was this tested: manually built and verified

3. Any docs updates needed?
…#970)

## Summary
- Bump `go.temporal.io/server` from v1.31.0-151.6 to v1.31.0-152.2 to
resolve CVEs
- Bump Go from 1.26.0 to 1.26.1, fixing 5 stdlib vulnerabilities
(GO-2026-4599 through GO-2026-4603)

## Test plan
- [ ] CI passes
@jaypipes jaypipes requested review from a team as code owners March 31, 2026 15:57
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 31, 2026

CLA assistant check
All committers have signed the CLA.

@jaypipes jaypipes force-pushed the jaypipes/serverless branch from 4dded90 to 765f4f8 Compare March 31, 2026 16:19
@jaypipes jaypipes force-pushed the jaypipes/serverless branch 2 times, most recently from 935a0d6 to aa347d3 Compare April 1, 2026 14:51
@chaptersix
Copy link
Copy Markdown
Contributor

chaptersix commented Apr 1, 2026

TODO: add unit tests.

Generally it'd be great to have tests coverage that matches existing coverage for worker deployments. IIRC there's some tests that hit the dev server.

@chaptersix
Copy link
Copy Markdown
Contributor

CI failures seem relevant to this change.

…io#972)

## Summary

- Removes `experimental: true` from `--config-file`, `--profile`,
`--disable-config-file`, and `--disable-config-env` global flags in
`cliext/option-sets.yaml`
- Regenerates `cliext/flags.gen.go` to remove the `EXPERIMENTAL.` suffix
from the help strings for those flags

## Test plan

- [ ] Run `temporal --help` and verify the four flags no longer show
`EXPERIMENTAL.` in their descriptions
- [ ] Run `make build` to confirm clean build

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
spkane31 and others added 2 commits April 6, 2026 16:16
…lio#974)

## What was changed

- activity pause silently ignored the `--identity` flag, always sending
the global client identity instead of the per-command one
- activity pause had no `--reason` flag despite the server-side
`PauseActivityRequest` accepting one
- `--activity-type` showed `activity-id` as its value placeholder in
pause, unpause, and reset help output
- `--reset-heartbeats` on unpause and reset incorrectly claimed it only
works with `--reset-attempts`
- activity complete and activity fail lacked the `-a` shorthand for
`--activity-id` that the other activity subcommands already had

## Why?
These were found during an internal bug bash as either bugs or
inconsistencies.

## Checklist
1. Closes NA
2. How was this tested: Manually
3. Any docs updates needed? No
…ralio#975)

## Summary

- Upgrades `go.temporal.io/sdk` from v1.38.0 to v1.41.0 in both root and
`cliext` modules
- Upgrades `go.temporal.io/sdk/contrib/envconfig` from v0.1.0 to v1.0.0
in both modules

## Why

envconfig v0.1.0 had a bug where `ToClientOptions` did not set
`ConnectionOptions.TLSDisabled = true` when a profile had TLS disabled.
This meant that passing `--api-key X --tls=false` would still dial with
TLS enabled (because the SDK auto-enables TLS when credentials are
present), overriding the user's explicit `--tls=false` flag.

Fixed upstream in temporalio/sdk-go#2205, released in envconfig v1.0.0.
@jaypipes jaypipes force-pushed the jaypipes/serverless branch 2 times, most recently from 6e071ed to 058ec54 Compare April 8, 2026 22:48
@jaypipes jaypipes force-pushed the jaypipes/serverless branch 2 times, most recently from ab657bb to bd0ea09 Compare April 9, 2026 22:22
@jaypipes jaypipes changed the title add temporal worker deployment create-version temporal worker deployment create|create-version Apr 9, 2026
@jaypipes jaypipes force-pushed the jaypipes/serverless branch 3 times, most recently from 33f8cc0 to 050c38f Compare April 13, 2026 19:56
@jaypipes jaypipes force-pushed the jaypipes/serverless branch 2 times, most recently from aef9b0b to 3b3700c Compare April 14, 2026 17:08
Adds implementation of the `temporal worker deployment create` and
`temporal worker deployment create-version` CLI commands using only
direct gRPC API calls, not the sdk-go client code.

Adds some basic unit tests for both commands though due to the
server-side validation of proper AWS IAM credentials, the happy-path
`temporal worker deployment create-version` call with AWS Lambda compute
config is skipped until such time as we can figure out adding real AWS
test fixtures.

Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
@jaypipes jaypipes force-pushed the jaypipes/serverless branch from 3b3700c to d10e336 Compare April 14, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants