Add per-SDK examples for upgrade-on-Continue-as-New#4653
Open
donald-pinckney wants to merge 5 commits into
Open
Add per-SDK examples for upgrade-on-Continue-as-New#4653donald-pinckney wants to merge 5 commits into
donald-pinckney wants to merge 5 commits into
Conversation
The "Upgrading on Continue-as-New" section only showed a Go code sample. Wrap it in an <SdkTabs> block matching the rest of the file and add verified Java, Python, TypeScript, and .NET examples using each SDK's target-version-changed flag and AUTO_UPGRADE initial versioning behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
Verified against temporalio/sdk-ruby#404 (worker_workflow_versioning_test.rb): target_worker_deployment_version_changed? plus ContinueAsNewError with initial_versioning_behavior: ContinueAsNewVersioningBehavior::AUTO_UPGRADE. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The lazy-moving limitation referenced the Go-specific method name and had a grammar slip; reword to the SDK-neutral "target-version-changed flag" since the section now covers all SDKs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
THardy98
approved these changes
Jun 4, 2026
jsundai
reviewed
Jun 4, 2026
| ``` | ||
|
|
||
| </SdkTabs.DotNet> | ||
| <SdkTabs.Ruby> |
Contributor
There was a problem hiding this comment.
It says Java, Python, TypeScript, and .NET in the description, is Ruby apart of it too? @donald-pinckney @THardy98
Contributor
Author
There was a problem hiding this comment.
Ah yes, Ruby is a part of it too. I added it in a 2nd commit and forgot to update the PR description!
Contributor
Author
There was a problem hiding this comment.
I have updated the description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Upgrading on Continue-as-New section of
worker-versioning.mdxonly had a Go code sample under "Checking for new versions." This wraps that sample in an<SdkTabs>block (matching the rest of the file) and adds equivalent examples for Java, Python, TypeScript, .NET and Ruby.Each example shows the same pattern as the existing Go code:
AUTO_UPGRADEso it starts on the Target Version.Workflow.getInfo().isTargetWorkerDeploymentVersionChanged()ContinueAsNewOptions ... InitialVersioningBehavior.AUTO_UPGRADEworkflow.info().is_target_worker_deployment_version_changed()initial_versioning_behavior=ContinueAsNewVersioningBehavior.AUTO_UPGRADEworkflowInfo().targetWorkerDeploymentVersionChangedmakeContinueAsNewFunc({ initialVersioningBehavior: InitialVersioningBehavior.AUTO_UPGRADE })Workflow.TargetWorkerDeploymentVersionChangedContinueAsNewOptions { InitialVersioningBehavior = InitialVersioningBehavior.AutoUpgrade }Temporalio::Workflow.target_worker_deployment_version_changed?raise Temporalio::Workflow::ContinueAsNewError.new(..., initial_versioning_behavior: Temporalio::ContinueAsNewVersioningBehavior::AUTO_UPGRADE)🤖 Generated with Claude Code
┆Attachments: EDU-6469 Add per-SDK examples for upgrade-on-Continue-as-New