Fix scripts for docker-compose examples to honor PostgreSQL/OpenSearch env vars#130
Merged
chaptersix merged 3 commits intotemporalio:mainfrom Mar 7, 2026
Merged
Conversation
…h env vars Changing PostgreSQL/OpenSearch settings in compose/scripts (db host, db username) could crash on first startup because init scripts were effectively using defaults instead of the compose-provided environment. Align the example configs so init scripts honor the environment variables passed from docker-compose.
|
|
Apply the same fix from the PostgreSQL scripts to the MySQL and Cassandra setup scripts, replacing hardcoded hostnames, usernames, and ports with compose-provided environment variables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thanks for the fix @bpteam! This is a good catch -- the setup scripts were silently ignoring the compose-provided environment variables. I applied the same fix to the MySQL and Cassandra setup scripts ( |
chaptersix
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Changing PostgreSQL/OpenSearch settings in compose/scripts (db host, db username) for using env variables from docker compose files
Why?
Changing PostgreSQL/OpenSearch settings in docker-compose (db host, db username) could crash on first startup because init scripts were effectively using defaults instead of the compose-provided environment.
How was this tested:
Run commands with changed scripts
docker compose -f compose/docker-compose.yml up
docker compose -f compose/docker-compose-postgres.yml up
docker compose -f compose/docker-compose-postgres-opensearch.yml up
Any docs updates needed?
No
Align the example configs so init scripts honor the environment variables
passed from docker-compose.