Conversation
mjameswh
approved these changes
Mar 30, 2026
eamsden
changed the title
SKIP_YIELD_ON_VERSION to initialFlagstryUseSdkFlag(SdkFlag.SKIP_YIELD_ON_VERSION) so that we default to enabling SKIP_YIELD_ON_VERSION when calling getVersion()
exception masking after multiple `getVersion()` calls
adding it to `initialFlags`
`SKIP_YIELD_ON_VERSION` by default corrects for the issue.
eamsden
force-pushed
the
eamsden/sdk-flags-getVersion
branch
from
7f6ff97 to
36215b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
SKIP_YIELD_ON_VERSIONtoWorkflowStateMachines.initialFlagsWhy?
This flag already fixes the behavior seen in #2810 but was not enabled by default and should be.
Checklist
Workflow.GetVersioncall can cause NDE if there are multiple parallel workflow threads running. #2307WorkflowFailureGetVersionTestwhich runs the exact reproduction from Workflow task failed with an internal Java SDK runner-closed error, masking the original workflow exception. #2810 and asserts that the actual exception thrown by the workflow is re-thrown, rather than an exception showing the worker was closed. This test was verified to fail without theSKIP_YIELD_ON_VERSIONSDK flag and to succeed with it.Workflow.GetVersioncall can cause NDE if there are multiple parallel workflow threads running. #2307 was updated so that it does not injectSKIP_YIELD_ON_VERSION, since that should now happen by default.No, this is a fix.